Skip to content

Fix cloud URL when Manage Jenkins UI is deferred #26107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 2 commits into from
Jan 14, 2026
Merged

Fix cloud URL when Manage Jenkins UI is deferred #26107

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb3df8b
Fix cloud URL when Manage Jenkins UI is deferred
ollehu Jan 12, 2026
2ba0613
Prefer noDefer over safeguarding getCloudUrl
ollehu Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/java/jenkins/agents/CloudSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@
@Restricted(DoNotUse.class) // stapler
public String getCloudUrl(StaplerRequest2 request, Jenkins jenkins, Cloud cloud) {
String context = Functions.getNearestAncestorUrl(request, jenkins);
if (context == null) {
context = Util.fixNull(request.getContextPath());

Check warning on line 117 in core/src/main/java/jenkins/agents/CloudSet.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered lines 

Lines 116-117 are not covered by tests
}
if (Jenkins.get().getCloud(cloud.name) != cloud) { // this cloud is not the first occurrence with this name
return context + "/cloud/cloudByIndex/" + getClouds().indexOf(cloud) + "/";
} else {
Expand Down
Loading