Use display name in directory browser breadcrumbs by LakshyaBagani · Pull Request #25924 · jenkinsci/jenkins

LakshyaBagani · 2025-12-11T21:49:59Z

Fixes #16765

Testing done

Verified locally. The breadcrumb now correctly shows the display name instead of the internal name, which looks much better for jobs with custom display names.

UI Screenshots

After the change

Before the change

Proposed changelog entries

Use display name in directory browser breadcrumb.

Proposed changelog category

Improvement

Proposed upgrade guidelines

N/A

Submitter checklist

The issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @restricted or have @SInCE TODO Javadocs, as appropriate.
New deprecations are annotated with @deprecated(since = "TODO") or @deprecated(forRemoval = true, since = "TODO"), if applicable.
UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers
@timja @mawinter69 @daniel-beck @MarkEWaite

timja · 2025-12-11T22:02:09Z

Please include before and after screenshots for any ui change

daniel-beck

Please remove unrelated changes from this PR.

LakshyaBagani · 2025-12-12T01:18:00Z

Thanks for pointing it out! I’ve added the UI screenshots and will include before/after images in future PRs.

timja · 2025-12-12T07:33:29Z

you've only added after and the text before

LakshyaBagani · 2025-12-12T19:51:32Z

I’ve added the before screenshot as well.

daniel-beck · 2025-12-14T16:03:37Z

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

          <form>
-            <a href="${topPath}">${it.owner.name}</a> /
+            <j:choose>
+              <j:when test="${request2.originalRequestURI.contains('/artifact/')}">


This makes absolutely no sense.

If a job is called artifact, so the URL is /job/artifact/whatever, we go into this branch?

Also, why would we not do this for workspaces?

mawinter69 · 2025-12-14T17:44:48Z

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

+                <a href="${rootURL}/${it.owner.url}artifact/">${%Root}</a> /
+              </j:when>
+              <j:otherwise>
+                <a href="${topPath}">${it.owner.name}</a> /


Actually a link is already added. It's just that it.owner.name return nothing or is null, hence the link is not usable. So all that needs to be done is checking if it.owner.name is null or empty and then insert ${%Root} instead.

mawinter69 · 2025-12-14T17:58:49Z

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

+                <a href="${rootURL}/${it.owner.url}artifact/">${%Root}</a> /
+              </j:when>
+              <j:otherwise>
+                <a href="${topPath}">${it.owner.name}</a> /


Or as the owner is a ModelObject use it.owner.displayName as that is the only method that a ModelObject has.
Things you should check:

visit the workspace of a FreestyleProject

visit the artifacts attached from the job directly (uses lastSuccessfulBuild)

visit the artifacts attached from the run itself

visit the workspace(s) of a pipeline run

LakshyaBagani · 2025-12-14T21:01:02Z

Thanks @daniel-beck and @mawinter69 for the feedback.

I see the issue with checking request2.originalRequestURI — it would indeed break if a job was named "artifact".

Based on @mawinter69's suggestion, I'll update the approach to avoid the URL check entirely. Instead, I will check if it.owner.name is null or empty.
1 :- If it is empty, I'll default to ${%Root}.
2 :- Otherwise, I'll use it.owner.name (or it.owner.displayName).

I will also verify this behavior across:
1 :- Freestyle project workspaces
2 :- Job artifacts
3 :- Run artifacts
4 :- Pipeline run workspaces

I'll push the changes shortly.

LakshyaBagani · 2025-12-15T00:08:51Z

We removed the URL check entirely. Instead, we updated the logic in dir.jelly to:

1 :- Check if it.owner.name is empty.
2 :- If empty: Display "Root" (this fixes the Artifacts view).
3 :- If not empty: Display it.owner.displayName (this keeps Workspaces working correctly).

Is Further Work Required?
@daniel-beck @mawinter69

mawinter69

Please also update screenshots

mawinter69 · 2025-12-15T16:02:49Z

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

          <form>
-            <a href="${topPath}">${it.owner.name}</a> /
+            <a href="${topPath}">
+              <j:choose>


Just always use it.owner.displayname without a choose. No need to check for name alone, when you don't use it anyway.

LakshyaBagani · 2025-12-16T14:16:13Z

I had changed the code as per the requirement and also added the latest screenshot @daniel-beck @mawinter69

LakshyaBagani · 2025-12-30T18:23:32Z

@daniel-beck @mawinter69 any update in the PR . Do this required any further change or not ?

LakshyaBagani · 2026-01-15T19:00:23Z

Hi @daniel-beck , @timja and @mawinter69,
Thanks again for all the detailed feedback earlier — it really helped improve this change.

I’ve now:

Simplified the breadcrumb logic to always use it.owner.displayName
Removed the URL-based condition
Verified behavior across:
- Freestyle workspaces
- Job artifacts
- Run artifacts
- Pipeline run workspaces
Updated the before/after UI screenshots as requested

All checks are passing, and the branch is ready to merge once approved.

Could you please let me know if any further changes are needed, or if this is ready for final review?
Thanks for your time and guidance!

mawinter69 · 2026-01-15T19:07:30Z

Can you update the screenshots and the original PR description at the top to reflect the current state. It doesn't fit anymore to what was changed and what was tested

mawinter69

Otherwise it looks good I think

LakshyaBagani · 2026-01-15T19:32:27Z

Thanks for the suggestion!
I have updated the PR description and screenshots to reflect the current implementation and testing.

timja

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

timja · 2026-01-15T22:13:04Z

Please restore the PR template making sure a changelog entry is included:
https://github.com/jenkinsci/jenkins/blob/master/.github/PULL_REQUEST_TEMPLATE.md

LakshyaBagani · 2026-01-17T15:26:12Z

@timja just following up on this PR since it is already approved. Let me know if anything else is needed from my side before merging.

timja · 2026-01-17T15:32:27Z

Please restore the PR template making sure a changelog entry is included: master/.github/PULL_REQUEST_TEMPLATE.md

LakshyaBagani · 2026-01-17T22:21:22Z

Please restore the PR template making sure a changelog entry is included: master/.github/PULL_REQUEST_TEMPLATE.md

I had changed the PR description .

timja · 2026-01-17T22:36:37Z

Please restore the PR template making sure a changelog entry is included: master/.github/PULL_REQUEST_TEMPLATE.md

I had changed the PR description .

Not until 15 minutes ago. I hope you've just mistaken had and have.

timja · 2026-01-17T22:37:35Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

LakshyaBagani · 2026-01-17T22:40:42Z

Please restore the PR template making sure a changelog entry is included: master/.github/PULL_REQUEST_TEMPLATE.md

I had changed the PR description .

Not until 15 minutes ago. I hope you've just mistaken had and have.

Sorry for the grammatical mistake. I updated the PR description a few minutes ago .

obsolete

MarkEWaite

I tested interactively and found no issues. Thanks!

* Update dir.jelly logic for navigation * Fix the navigation * Change as per requirement * Change jelly

comment-ops-bot bot added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Dec 11, 2025

daniel-beck requested changes Dec 11, 2025

View reviewed changes

Update dir.jelly logic for navigation

c31574e

LakshyaBagani force-pushed the navigate-back-to-build-artifact branch from 696a163 to c31574e Compare December 11, 2025 22:43

Fix the navigation

e18ddd8

LakshyaBagani requested a review from daniel-beck December 12, 2025 20:54

daniel-beck previously requested changes Dec 14, 2025

View reviewed changes

mawinter69 reviewed Dec 14, 2025

View reviewed changes

mawinter69 suggested changes Dec 14, 2025

View reviewed changes

Change as per requirement

8203208

LakshyaBagani requested review from daniel-beck and mawinter69 December 15, 2025 02:20

mawinter69 suggested changes Dec 15, 2025

View reviewed changes

Change jelly

58a9b67

LakshyaBagani requested a review from mawinter69 December 16, 2025 14:16

mawinter69 approved these changes Jan 15, 2026

View reviewed changes

timja approved these changes Jan 15, 2026

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 15, 2026

timja removed the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 15, 2026

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 17, 2026

MarkEWaite changed the title ~~Navigate back to build artifact~~ Show display name of job in the breadcrumbs Jan 19, 2026

MarkEWaite changed the title ~~Show display name of job in the breadcrumbs~~ Show display name in the breadcrumbs Jan 19, 2026

MarkEWaite changed the title ~~Show display name in the breadcrumbs~~ Show display name in directory browser breadcrumbs Jan 19, 2026

MarkEWaite changed the title ~~Show display name in directory browser breadcrumbs~~ Use display name in directory browser breadcrumbs Jan 19, 2026

MarkEWaite approved these changes Jan 19, 2026

View reviewed changes

MarkEWaite merged commit 99c2f4d into jenkinsci:master Jan 19, 2026
23 checks passed

meetgoti07 pushed a commit to meetgoti07/jenkins that referenced this pull request Jan 29, 2026

Use display name in directory browser breadcrumbs (jenkinsci#25924)

8277337

* Update dir.jelly logic for navigation * Fix the navigation * Change as per requirement * Change jelly

Uh oh!

Conversation

LakshyaBagani commented Dec 11, 2025 • edited by MarkEWaite Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes #16765

Testing done

UI Screenshots

Proposed changelog entries

Proposed changelog category

Proposed upgrade guidelines

Submitter checklist

Uh oh!

timja commented Dec 11, 2025

Uh oh!

daniel-beck left a comment

Choose a reason for hiding this comment

Uh oh!

LakshyaBagani commented Dec 12, 2025

Uh oh!

timja commented Dec 12, 2025

Uh oh!

LakshyaBagani commented Dec 12, 2025

Uh oh!

daniel-beck Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

mawinter69 Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

mawinter69 Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

LakshyaBagani commented Dec 14, 2025

Uh oh!

LakshyaBagani commented Dec 15, 2025

Uh oh!

mawinter69 left a comment

Choose a reason for hiding this comment

Uh oh!

mawinter69 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

LakshyaBagani commented Dec 16, 2025

Uh oh!

LakshyaBagani commented Dec 30, 2025

Uh oh!

LakshyaBagani commented Jan 15, 2026

Uh oh!

mawinter69 commented Jan 15, 2026

Uh oh!

mawinter69 left a comment

Choose a reason for hiding this comment

Uh oh!

LakshyaBagani commented Jan 15, 2026

Uh oh!

timja left a comment

Choose a reason for hiding this comment

Uh oh!

timja commented Jan 15, 2026

Uh oh!

LakshyaBagani commented Jan 17, 2026

Uh oh!

timja commented Jan 17, 2026

Uh oh!

LakshyaBagani commented Jan 17, 2026

Uh oh!

timja commented Jan 17, 2026

Uh oh!

timja commented Jan 17, 2026

Uh oh!

LakshyaBagani commented Jan 17, 2026

Uh oh!

MarkEWaite left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

LakshyaBagani commented Dec 11, 2025 •

edited by MarkEWaite

Loading