-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Show build cause on experimental build UI #11128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show build cause on experimental build UI #11128
Conversation
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
|
|
Hmm a little odd, |
timja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested a couple of basic ones locally works good!
NotMyFault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
|
Looks wonderful! Much cleaner UI <3 What about Generic Webhook Trigger And how does it replace situation when there is cascade of triggers ? Will there be some dialog/subpage where we can check such pipeline relations ? |
Thanks! I'll take a look :)
It doesn't currently support a cascade of triggers, but it could definitely be updated to show a dialog of them on click. |
|
Given this is experimental we'll iterate it based on feedback so merging now. |
|
|
||
| <?jelly escape-by-default='true'?> | ||
| <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout"> | ||
| <j:forEach var="entry" items="${it.causeCounts.entrySet()}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.




This PR adds the build cause to the details bar on the experimental run UI. There's quite a few variations of this:
Started by a user
Upstream
Branch indexing
(requires jenkinsci/branch-api-plugin#555)
Remote cause
There's a fallback for causes that don't implement
detail.jelly- if there's a cause you want to see demonstrated in this UI let me know.I've also updated the ordering for the details, so that it follows the same order as
ordinals, in which the higher the number the sooner the object will appear.Testing done
Proposed changelog entries
Proposed changelog category
/label web-ui,rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).