-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add experimental 'Parameters' detail for runs #11116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental 'Parameters' detail for runs #11116
Conversation
1e556b3 to
78c8f15
Compare
| "-dialog-", | ||
| 1000, | ||
| (element) => { | ||
| element.addEventListener("click", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested this yet, is there a way to send a link that will have the parameters dialog open?
I imagine that's a relatively common use-case, to send a link to someone with the parameters for a build?
e.g. maybe a URL fragment #parameters that will auto open the dialog and clicking the link appends it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea - I've updated it so that the hash is set when opening, navigating to that url then opens the dialog.
Co-authored-by: Tim Jacomb <[email protected]>
timja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
This PR adds a quick way to view Parameters for a run for the experimental run page.
The intention behind this is to:
This PR also adds a
<l:dialog />component, making it easy for developers to display dialogs with deferred loading of their contents, built on top of the existingrenderOnDemand.Testing done
Proposed changelog entries
Proposed changelog category
/label web-ui,rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).