Skip to content

Conversation

@janfaracik
Copy link
Member

@janfaracik janfaracik commented Sep 26, 2025

This PR adds a quick way to view Parameters for a run for the experimental run page.

The intention behind this is to:

  • Reduce items in the sidepanel
  • Keep details of a run together
  • Avoid disrupting the user's context by opening the dialog on the same page
  • Improve performance by avoiding a full page reload
  • Make it easy to copy past parameters
Screenshot 2025-09-26 at 07 43 21 image

This PR also adds a <l:dialog /> component, making it easy for developers to display dialogs with deferred loading of their contents, built on top of the existing renderOnDemand.

Testing done

  • Button hides for non-parameterised runs
  • Button appears for parameterised runs

Proposed changelog entries

  • Add experimental 'Parameters' dialog for builds

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Sep 26, 2025
@janfaracik janfaracik requested a review from a team September 26, 2025 06:47
@janfaracik janfaracik force-pushed the add-parameters-detail branch from 1e556b3 to 78c8f15 Compare September 26, 2025 07:42
"-dialog-",
1000,
(element) => {
element.addEventListener("click", () => {
Copy link
Member

@timja timja Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested this yet, is there a way to send a link that will have the parameters dialog open?
I imagine that's a relatively common use-case, to send a link to someone with the parameters for a build?

e.g. maybe a URL fragment #parameters that will auto open the dialog and clicking the link appends it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - I've updated it so that the hash is set when opening, navigating to that url then opens the dialog.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@timja timja requested a review from a team September 26, 2025 14:31
@timja
Copy link
Member

timja commented Sep 26, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 26, 2025
@krisstern krisstern merged commit 1b0b8bf into jenkinsci:master Sep 28, 2025
17 checks passed
@janfaracik janfaracik mentioned this pull request Sep 29, 2025
14 tasks
@janfaracik janfaracik deleted the add-parameters-detail branch October 14, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants