Skip to content

Conversation

@jglick
Copy link
Member

@jglick jglick commented Sep 18, 2025

See JENKINS-16341.

Like #11084, picks up jenkinsci/stapler#663, but also cleans up from aac8c23 as in jenkinsci/stapler#663 (comment).

Testing done

After jetty:run, /view/all/builds shows something.

Proposed changelog entries

  • Try harder to release controller memory after using some JavaScript features.

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Sep 18, 2025
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving removal of reflection, actual change is approved upstream.

Untested.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 19, 2025
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MarkEWaite MarkEWaite merged commit 1bae0f3 into jenkinsci:master Sep 20, 2025
18 checks passed
@jglick jglick deleted the BoundObjectTable branch September 20, 2025 19:00
lemeurherve pushed a commit to lemeurherve/jenkins that referenced this pull request Oct 23, 2025
lemeurherve pushed a commit to lemeurherve/jenkins that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants