[JENKINS-73161] Ensure file parameters are retained across Jenkins restarts #11081
+190
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…starts Save the file as temporary file and store the filename in the value That way we can recover the file
comment-ops-bot
bot
added
the
bug
6 tasks
This comment was marked as outdated.
This comment was marked as outdated.
needed to be able to apply the annotation
jglick
approved these changes
Sep 25, 2025
Member
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Looks OK (did not review too closely).
| locationFilePath.delete(); | ||
| if (location != null && !location.isBlank() && file != null && file.getName() != null && !file.getName().isBlank()) { | ||
| try { | ||
| listener.getLogger().println("Copying file to " + location); |
timja
approved these changes
Sep 26, 2025
NotMyFault
approved these changes
Sep 28, 2025
Member
NotMyFault
left a comment
NotMyFault
left a comment
There was a problem hiding this comment.
/label ready-for-merge
This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!
comment-ops-bot
bot
added
the
ready-for-merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save the file as temporary file and store the filename in the value. That way we can recover the file parameter on a restart.
See JENKINS-73161.
Testing done
Added a unit test that fails without the fix
Manually verified that when deleting a freestyle job from the queue that the temporary file is deleted.
Manually verified that the temporary file is deleted once the job starts running
Proposed changelog entries
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).