Skip to content

[JENKINS-76002] Apply number instead of string comparison #11059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 1 commit into from
Sep 17, 2025
Merged

[JENKINS-76002] Apply number instead of string comparison #11059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions war/src/main/webapp/scripts/hudson-behavior.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,16 +821,16 @@ function registerMinMaxValidator(e) {
}

if (isInteger(this.value)) {
const valueInt = parseInt(this.value);

// Ensure the value is an integer
if (min !== null && isInteger(min) && max !== null && isInteger(max)) {
// Both min and max attributes are available

if (min <= max) {
const minInt = parseInt(min);
const maxInt = parseInt(max);
if (minInt <= maxInt) {
// Add the validator if min <= max
if (
parseInt(min) > parseInt(this.value) ||
parseInt(this.value) > parseInt(max)
) {
if (minInt > valueInt || valueInt > maxInt) {
// The value is out of range
updateValidationArea(
this.targetElement,
Expand All @@ -850,7 +850,8 @@ function registerMinMaxValidator(e) {
) {
// There is only 'min' available

if (parseInt(min) > parseInt(this.value)) {
const minInt = parseInt(min);
if (minInt > valueInt) {
updateValidationArea(
this.targetElement,
`<div class="error">This value should be larger than ${min}</div>`,
Expand All @@ -868,7 +869,8 @@ function registerMinMaxValidator(e) {
) {
// There is only 'max' available

if (parseInt(max) < parseInt(this.value)) {
const maxInt = parseInt(max);
if (maxInt < valueInt) {
updateValidationArea(
this.targetElement,
`<div class="error">This value should be less than ${max}</div>`,
Expand Down
Loading