-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Removed configureclouds redirect
#10982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
daniel-beck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| <?jelly escape-by-default='true'?> | ||
| <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler"> | ||
| <st:redirect url="../manage/cloud/" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also used a curl command
curl -vLto verify that it is working:
Due to .. use here instead of rootURL as before (and the insanity coming from #6126), the result is a little awkward with /manage/configureClouds which was the most likely URL though which the old configuration was accessed.
| <st:redirect url="../manage/cloud/" /> | |
| <st:redirect url="../cloud/" /> |
is probably a better approach, as it should neither add nor remove /manage/ (untested).
I guess it shouldn't matter anymore. |
timja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think best to remove this now
|
Ok, I will adjust the PR |
configureclouds redirect from groovy to jellyconfigureclouds redirect
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
Removed
configurecloudsredirect, since the move was done in2.403Testing done
started jenkins in debug and verified that clouds still open
Proposed changelog entries
configurecloudsredirect to clouds.Proposed changelog category
/label
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).