Revert "[JENKINS-75465] Delete RunIdMigrator as it has been 10 years since this migration"#10517
Merged
MarkEWaite merged 4 commits intomasterfrom Apr 8, 2025
Merged
Conversation
…since this migration"
Contributor
Author
|
/label skip-changelog |
MarkEWaite
added
the
work-in-progress
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Apr 8, 2025
Leave the commit as only the revert of the original change This reverts commit 2cf37a1.
gbhat618
approved these changes
Apr 8, 2025
Contributor
|
thank you for noticing the failures and helping unblock @MarkEWaite |
krisstern
approved these changes
Apr 8, 2025
MarkEWaite
removed
the
work-in-progress
gbhat618
added a commit
to gbhat618/jenkins
that referenced
this pull request
Apr 8, 2025
… since this migration" (jenkinsci#10517) This reverts commit c769824.
gbhat618
added a commit
to gbhat618/jenkins
that referenced
this pull request
Apr 8, 2025
… since this migration" (jenkinsci#10517) This reverts commit c769824.
This was referenced Apr 9, 2025
gbhat618
added a commit
to gbhat618/unique-id-plugin
that referenced
this pull request
Apr 10, 2025
…ld dirs to numerical Two tests were failing in BOM for the change in jenkinsci/jenkins#10521, * IdStoreMigratorV1ToV2Test#testMigration * IdStoreMigratorV1ToV2Test#testMigrationLongLoadingBuilds (failure was reported by jenkinsci/jenkins#10517) Reason for the failure was the build dirs inside the zip were named with datetime format 'yyyy-MM-dd_HH-mm-ss', which used to get dynamically converted to numerical format during runtime by `RunIdMigrator`. However with the `RunIdMigrator` removal, this conversion no longer happens, and tests failed. This PR fixes the zip files, and thus unblocking jenkinsci/jenkins#10521.
6 tasks
gbhat618
added a commit
to gbhat618/dockerhub-notification-plugin
that referenced
this pull request
Apr 10, 2025
…o keep it unzipped While removing the `RunIdMigrator`, it was noticed that `BackCompat102Test` test class was failing in BOM weekly tests. Reported in jenkinsci/jenkins#10517. The reason is build directories were historically named in `yyyy-MM-dd_HH-mm-ss` format, which was changed to numerical format in 2015 Jan. However the zip file in here was still working because `RunIdMigrator` was renaming during runtime. As `RunIdMigrator` is getting removed we need to fix these directory names. Also since Zip files are hard to compare -- unzipping and checking in the files with, * build folder renamed to numerical format * <timestamp> tag is put in `build.xml` instead of `<number>`. * update the buildIds in fingerprint files as the name changed from date-time format to numerical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #10456
Confirmed that this revert was enough to fix the test failures in plugin BOM: