Attempt Deflake - Disable JS in FileParameterValueTest and DirectoryBrowserSupportTest by gbhat618 · Pull Request #10471 · jenkinsci/jenkins

gbhat618 · 2025-03-26T14:10:32Z

This PR proposes to disable the javascript in WebClient in all places in the mentioned two test classes,

as several of these tests can be potentially affected - the ones visiting the ws URL.
and since getWebClient() is now called in several methods, to keep consistency with the entire class - using it all methods.

Besides possibly it fixing the flakiness, it speeds up the tests (slowness affected by jenkinsci/jenkins-test-harness#946),

Test Class	Execution time before	Execution time after
FileParameterValueTest	`01:29 min`	`23.766s`
DirectoryBrowserSupportTest	`02:49 min`	`37.973 s`

Noticed that two tests failed in CI with same kind of error,

FileParameterValueTest#fileParameter_canStillUse_internalHierarchy
DirectoryBrowserSupportTest.tmpNotListed

failure log

java.lang.NullPointerException: Cannot invoke "org.htmlunit.html.DomElement.getHtmlElementDescendants()" because "doc" is null
	at org.htmlunit.html.HtmlPage.executeDeferredScriptsIfNeeded(HtmlPage.java:1466)
	at org.htmlunit.html.HtmlPage.initialize(HtmlPage.java:265)
	at org.htmlunit.WebClient.loadWebResponseInto(WebClient.java:701)
	at org.htmlunit.WebClient.loadWebResponseInto(WebClient.java:575)
	at org.htmlunit.WebClient.getPage(WebClient.java:493)
	at org.htmlunit.WebClient.getPage(WebClient.java:402)
	at org.htmlunit.WebClient.getPage(WebClient.java:538)
	at org.htmlunit.WebClient.getPage(WebClient.java:520)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.getPage(JenkinsRule.java:2740)
	at org.jvnet.hudson.test.JenkinsRule.after(JenkinsRule.java:519)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:677)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:840)

Example CI Failure reports

Test	Failure
`FileParameterValueTest#fileParameter_canStillUse_internalHierarchy`	PR-10456 (ref failed test result)
`FileParameterValueTest#fileParameter_canStillUse_internalHierarchy`	PR-10467 (ref failed test result)
`DirectoryBrowserSupportTest.tmpNotListed`	PR-10470 (ref failed test result)

I didn't reproduce the error, but hopefully it fixes the flakiness, possibly causes by the javascript issue.

example showing slowness

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running hudson.model.FileParameterValueTest
=== Starting fileParameter_canStillUse_internalHierarchy(hudson.model.FileParameterValueTest)
   0.047 [id=21]	INFO	o.jvnet.hudson.test.WarExploder#explode: Using jenkins.war resources from /.../jenkins/war/target/jenkins
   0.304 [id=21]	INFO	o.jvnet.hudson.test.JenkinsRule#createWebServer2: Running on http://localhost:64862/jenkins/
   0.367 [id=21]	INFO	jenkins.model.Jenkins#<init>: Starting version 2.504-SNAPSHOT
   0.421 [id=36]	INFO	jenkins.InitReactorRunner$1#onAttained: Started initialization
   1.002 [id=46]	INFO	hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/command-launcher.jpi as a dependency of gradle
   1.012 [id=46]	INFO	hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/apache-httpcomponents-client-4-api.jpi as a dependency of gradle
   1.034 [id=46]	INFO	hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/jdk-tool.jpi as a dependency of gradle
   1.052 [id=46]	INFO	hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/trilead-api.jpi as a dependency of gradle
   1.079 [id=46]	INFO	hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/eddsa-api.jpi as a dependency of gradle
   1.084 [id=46]	INFO	hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/gson-api.jpi as a dependency of gradle
   1.098 [id=46]	INFO	hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/mina-sshd-api-common.jpi as a dependency of gradle
   1.109 [id=46]	INFO	hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/mina-sshd-api-core.jpi as a dependency of gradle
   1.134 [id=46]	INFO	hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/sshd.jpi as a dependency of gradle
   1.353 [id=41]	INFO	jenkins.InitReactorRunner$1#onAttained: Listed all plugins
   1.362 [id=37]	INFO	j.b.api.BouncyCastlePlugin#start: /.../jenkins/test/target/j h15288515834251035408/plugins/bouncycastle-api/WEB-INF/optional-lib not found; for non RealJenkinsRule this is fine and can be ignored.
   1.931 [id=53]	INFO	jenkins.InitReactorRunner$1#onAttained: Prepared all plugins
   1.937 [id=34]	INFO	jenkins.InitReactorRunner$1#onAttained: Started all plugins
   1.937 [id=47]	INFO	jenkins.InitReactorRunner$1#onAttained: Augmented all extensions
   2.254 [id=53]	INFO	jenkins.InitReactorRunner$1#onAttained: System config loaded
   2.255 [id=53]	INFO	jenkins.InitReactorRunner$1#onAttained: System config adapted
   2.255 [id=37]	INFO	jenkins.InitReactorRunner$1#onAttained: Loaded all jobs
   2.255 [id=37]	INFO	jenkins.InitReactorRunner$1#onAttained: Configuration for all jobs updated
   2.307 [id=50]	INFO	jenkins.InitReactorRunner$1#onAttained: Completed initialization
   2.466 [test0 #1] Started by user SYSTEM
   2.466 [test0 #1] Running as SYSTEM
   2.466 [test0 #1] Building in workspace /.../jenkins/test/target/j h15288515834251035408/workspace/test0
   2.466 [test0 #1] Copying file to direct-child1.txt
   2.466 [test0 #1] Copying file to parent/child2.txt
   2.899 [test0 #1] Finished: SUCCESS
   3.046 [id=21]	INFO	h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: getting ws
  14.449 [id=21]	INFO	h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: got htmlunit for ws
  14.450 [id=21]	INFO	h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: got ws
  14.452 [id=21]	INFO	h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: getting ws/parent
  24.720 [id=21]	INFO	h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: got htmlunit for ws/parent
  24.733 [id=21]	INFO	h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: got ws/parent
  24.733 [id=21]	INFO	h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: completed
  34.767 [id=21]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Stopping Jenkins
WARN: The method class org.apache.commons.logging.impl.SLF4JLogFactory#release() was invoked.
WARN: Please see http://www.slf4j.org/codes.html#release for an explanation.
  34.799 [id=21]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Jenkins stopped
  34.840 [id=21]	INFO	o.j.h.t.TemporaryDirectoryAllocator#dispose: deleting /.../jenkins/test/target/j h15288515834251035408
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.15 s -- in hudson.model.FileParameterValueTest

Testing done

Tests run in local, and faster

Before: execution summary log

[WARNING] Tests run: 22, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 160.0 s -- in hudson.model.DirectoryBrowserSupportTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 22, Failures: 0, Errors: 0, Skipped: 2
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:49 min
[INFO] Finished at: 2025-03-27T20:58:02+05:30
[INFO] ------------------------------------------------------------------------


[WARNING] Tests run: 11, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 85.56 s -- in hudson.model.FileParameterValueTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 11, Failures: 0, Errors: 0, Skipped: 1
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:29 min
[INFO] Finished at: 2025-03-27T21:13:11+05:30
[INFO] ------------------------------------------------------------------------

After: execution summary log

[WARNING] Tests run: 22, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 28.58 s -- in hudson.model.DirectoryBrowserSupportTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 22, Failures: 0, Errors: 0, Skipped: 2
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  37.973 s
[INFO] Finished at: 2025-03-27T20:43:10+05:30
[INFO] ------------------------------------------------------------------------


[WARNING] Tests run: 11, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 14.90 s -- in hudson.model.FileParameterValueTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 11, Failures: 0, Errors: 0, Skipped: 1
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  23.766 s
[INFO] Finished at: 2025-03-27T20:49:39+05:30
[INFO] ------------------------------------------------------------------------

Proposed changelog entries

Proposed changelog category

/label skip-changelog,tests

Proposed upgrade guidelines

N/A

Submitter checklist

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

…archy Test failure The test `hudson.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy` failed in CI with error, <details><summary>failure log</summary> ``` java.lang.NullPointerException: Cannot invoke "org.htmlunit.html.DomElement.getHtmlElementDescendants()" because "doc" is null at org.htmlunit.html.HtmlPage.executeDeferredScriptsIfNeeded(HtmlPage.java:1466) at org.htmlunit.html.HtmlPage.initialize(HtmlPage.java:265) at org.htmlunit.WebClient.loadWebResponseInto(WebClient.java:701) at org.htmlunit.WebClient.loadWebResponseInto(WebClient.java:575) at org.htmlunit.WebClient.getPage(WebClient.java:493) at org.htmlunit.WebClient.getPage(WebClient.java:402) at org.htmlunit.WebClient.getPage(WebClient.java:538) at org.htmlunit.WebClient.getPage(WebClient.java:520) at org.jvnet.hudson.test.JenkinsRule$WebClient.getPage(JenkinsRule.java:2740) at org.jvnet.hudson.test.JenkinsRule.after(JenkinsRule.java:519) at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:677) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.lang.Thread.run(Thread.java:840) ``` </details> This is noticed in couple of PRs failing currently, * jenkinsci#10456 ([ref failed test result](https://ci.jenkins.io/job/Core/job/jenkins/job/PR-10456/7/testReport/)) * jenkinsci#10467 ([ref failed test result](https://ci.jenkins.io/job/Core/job/jenkins/job/PR-10467/2/testReport/)) I haven't been able to reproduce in local, but theory is these below mentioned delays could be the cause, * there is a slowness noticed in calls `wc.goTo(p.getUrl()...)` taking `~10s`. * And once the test is complete the stopping is taking another `10s`. <details><summary>log</summary> ``` [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running hudson.model.FileParameterValueTest === Starting fileParameter_canStillUse_internalHierarchy(hudson.model.FileParameterValueTest) 0.047 [id=21] INFO o.jvnet.hudson.test.WarExploder#explode: Using jenkins.war resources from /.../jenkins/war/target/jenkins 0.304 [id=21] INFO o.jvnet.hudson.test.JenkinsRule#createWebServer2: Running on http://localhost:64862/jenkins/ 0.367 [id=21] INFO jenkins.model.Jenkins#<init>: Starting version 2.504-SNAPSHOT 0.421 [id=36] INFO jenkins.InitReactorRunner$1#onAttained: Started initialization 1.002 [id=46] INFO hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/command-launcher.jpi as a dependency of gradle 1.012 [id=46] INFO hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/apache-httpcomponents-client-4-api.jpi as a dependency of gradle 1.034 [id=46] INFO hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/jdk-tool.jpi as a dependency of gradle 1.052 [id=46] INFO hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/trilead-api.jpi as a dependency of gradle 1.079 [id=46] INFO hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/eddsa-api.jpi as a dependency of gradle 1.084 [id=46] INFO hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/gson-api.jpi as a dependency of gradle 1.098 [id=46] INFO hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/mina-sshd-api-common.jpi as a dependency of gradle 1.109 [id=46] INFO hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/mina-sshd-api-core.jpi as a dependency of gradle 1.134 [id=46] INFO hudson.PluginManager#considerDetachedPlugin: Loading a detached plugin /var/folders/80/w8mmdy513sb3y9fp5fr7vvqc0000gn/T/jenkins1642946911825735225/sshd.jpi as a dependency of gradle 1.353 [id=41] INFO jenkins.InitReactorRunner$1#onAttained: Listed all plugins 1.362 [id=37] INFO j.b.api.BouncyCastlePlugin#start: /.../jenkins/test/target/j h15288515834251035408/plugins/bouncycastle-api/WEB-INF/optional-lib not found; for non RealJenkinsRule this is fine and can be ignored. 1.931 [id=53] INFO jenkins.InitReactorRunner$1#onAttained: Prepared all plugins 1.937 [id=34] INFO jenkins.InitReactorRunner$1#onAttained: Started all plugins 1.937 [id=47] INFO jenkins.InitReactorRunner$1#onAttained: Augmented all extensions 2.254 [id=53] INFO jenkins.InitReactorRunner$1#onAttained: System config loaded 2.255 [id=53] INFO jenkins.InitReactorRunner$1#onAttained: System config adapted 2.255 [id=37] INFO jenkins.InitReactorRunner$1#onAttained: Loaded all jobs 2.255 [id=37] INFO jenkins.InitReactorRunner$1#onAttained: Configuration for all jobs updated 2.307 [id=50] INFO jenkins.InitReactorRunner$1#onAttained: Completed initialization 2.466 [test0 jenkinsci#1] Started by user SYSTEM 2.466 [test0 jenkinsci#1] Running as SYSTEM 2.466 [test0 jenkinsci#1] Building in workspace /.../jenkins/test/target/j h15288515834251035408/workspace/test0 2.466 [test0 jenkinsci#1] Copying file to direct-child1.txt 2.466 [test0 jenkinsci#1] Copying file to parent/child2.txt 2.899 [test0 jenkinsci#1] Finished: SUCCESS 3.046 [id=21] INFO h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: getting ws 14.449 [id=21] INFO h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: got htmlunit for ws 14.450 [id=21] INFO h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: got ws 14.452 [id=21] INFO h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: getting ws/parent 24.720 [id=21] INFO h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: got htmlunit for ws/parent 24.733 [id=21] INFO h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: got ws/parent 24.733 [id=21] INFO h.model.FileParameterValueTest#fileParameter_canStillUse_internalHierarchy: completed 34.767 [id=21] INFO hudson.lifecycle.Lifecycle#onStatusUpdate: Stopping Jenkins WARN: The method class org.apache.commons.logging.impl.SLF4JLogFactory#release() was invoked. WARN: Please see http://www.slf4j.org/codes.html#release for an explanation. 34.799 [id=21] INFO hudson.lifecycle.Lifecycle#onStatusUpdate: Jenkins stopped 34.840 [id=21] INFO o.j.h.t.TemporaryDirectoryAllocator#dispose: deleting /.../jenkins/test/target/j h15288515834251035408 [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.15 s -- in hudson.model.FileParameterValueTest ``` </details>

test/src/test/java/hudson/model/FileParameterValueTest.java

gbhat618 · 2025-03-26T14:30:58Z

Checking the WebClients logs after LoggerRule enabling - logs in https://gist.github.com/gbhat618/012412c587559ef8e96efc9c0bd00d69

Edit: now filed jenkinsci/jenkins-test-harness#946

…ous ~40s

test/src/test/java/hudson/model/FileParameterValueTest.java

jglick

Did not look at details at all, but it is commonplace to need to disable JS in WebClient to make tests run more quickly or reliably, assuming of course that the test assertions are not specifically checking something dynamic in the page.

…SupportTest These two tests looked like frequently failing in the test paths that visit a builds `ws` page, which is having the javascript execution issue jenkinsci/jenkins-test-harness#946 Here trying to disable the javascript in all the webclient usages in these two tests. Note, I have disabled in the test methods that didn't visit the `ws` page specifially to keep the `getWebClient()` usage uniform.

gbhat618 · 2025-03-27T16:07:24Z

test/src/test/java/hudson/model/FileParameterValueTest.java

-        JenkinsRule.WebClient wc = j.createWebClient();
+        JenkinsRule.WebClient wc = getWebClient();
        wc.getOptions().setThrowExceptionOnFailingStatusCode(false);
    }


(seems like it was missed to check the intent // ensure also the file is not reachable by request (from commit)- I will file a separate PR for completing this test, should be couple of lines only)

gbhat618 · 2025-03-27T16:07:38Z

test/src/test/java/hudson/model/FileParameterValueTest.java

-        JenkinsRule.WebClient wc = j.createWebClient();
+        JenkinsRule.WebClient wc = getWebClient();
        wc.getOptions().setThrowExceptionOnFailingStatusCode(false);
    }


timja

Looks ok in this case I would be wary of doing this too much as users will be running with JavaScript on in almost all cases and what if the experience breaks in that case.

I've checked the tests here and it seems fine for this though

krisstern · 2025-03-28T09:54:51Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

A1exKH

LGTM.

gbhat618 commented Mar 26, 2025

View reviewed changes

test/src/test/java/hudson/model/FileParameterValueTest.java Show resolved Hide resolved

Enable LoggerRule for WebClient

0a394ea

gbhat618 force-pushed the debug-fileParameter_canStillUse_internalHierarchy-test-failures branch from df441f2 to 0a394ea Compare March 26, 2025 14:47

Disable javascript explicitely test method is running in ~5s vs previ…

0f3008d

…ous ~40s

gbhat618 commented Mar 26, 2025

View reviewed changes

test/src/test/java/hudson/model/FileParameterValueTest.java Outdated Show resolved Hide resolved

This was referenced Mar 26, 2025

Fix DefaultCredentialsStore javadoc #10470

Merged

[JENKINS-75465] Delete RunIdMigrator as it has been 10 years since this migration #10456

Merged

jglick approved these changes Mar 26, 2025

View reviewed changes

krisstern added the skip-changelog Should not be shown in the changelog label Mar 26, 2025

This was referenced Mar 27, 2025

[DEBUG] WebClientUtil calls WebClient#waitForBackgroundJavaScript with 10s always jenkinsci/jenkins-test-harness#945

Closed

WebClient.goTo requests cause 10s wasted delay for each call jenkinsci/jenkins-test-harness#946

Closed

gbhat618 changed the title ~~[DEBUG] FileParameterValueTest#fileParameter_canStillUse_internalHierarchy Test failure~~ Attempt Deflake - Disable JS in FileParameterValueTest and DirectoryBrowserSupportTest Mar 27, 2025

gbhat618 marked this pull request as ready for review March 27, 2025 16:04

gbhat618 commented Mar 27, 2025

View reviewed changes

jglick approved these changes Mar 27, 2025

View reviewed changes

timja approved these changes Mar 28, 2025

View reviewed changes

comment-ops-bot bot added the tests This PR adds/removes/updates test cases label Mar 28, 2025

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 28, 2025

krisstern requested a review from Vlatombe March 28, 2025 09:56

Vlatombe approved these changes Mar 28, 2025

View reviewed changes

A1exKH approved these changes Mar 28, 2025

View reviewed changes

krisstern merged commit 1a3b90f into jenkinsci:master Apr 2, 2025
19 checks passed

gbhat618 deleted the debug-fileParameter_canStillUse_internalHierarchy-test-failures branch April 2, 2025 16:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Attempt Deflake - Disable JS in FileParameterValueTest and DirectoryBrowserSupportTest#10471

Attempt Deflake - Disable JS in FileParameterValueTest and DirectoryBrowserSupportTest#10471
krisstern merged 4 commits intojenkinsci:masterfrom
gbhat618:debug-fileParameter_canStillUse_internalHierarchy-test-failures

gbhat618 commented Mar 26, 2025 •

edited by krisstern

Loading

Uh oh!

Uh oh!

gbhat618 commented Mar 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

jglick left a comment

Uh oh!

gbhat618 Mar 27, 2025 •

edited

Loading

Uh oh!

gbhat618 Mar 27, 2025

Uh oh!

timja left a comment

Uh oh!

krisstern commented Mar 28, 2025

Uh oh!

A1exKH left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

gbhat618 commented Mar 26, 2025 • edited by krisstern Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing done

Proposed changelog entries

Proposed changelog category

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

Uh oh!

Uh oh!

gbhat618 commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jglick left a comment

Choose a reason for hiding this comment

Uh oh!

gbhat618 Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gbhat618 Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

timja left a comment

Choose a reason for hiding this comment

Uh oh!

krisstern commented Mar 28, 2025

Uh oh!

A1exKH left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gbhat618 commented Mar 26, 2025 •

edited by krisstern

Loading

gbhat618 commented Mar 26, 2025 •

edited

Loading

gbhat618 Mar 27, 2025 •

edited

Loading