Allow wider range of file system times#910
Merged
MarkEWaite merged 2 commits intojenkinsci:masterfrom Jun 19, 2020
Merged
Conversation
Tests consistently fail with the 1500 ms range and consistently succeed with the 3000 ms range. OpenBSD file system appears to report times on second boundaries, with only zeroes in millisecond values.
Sometimes seeing failures reported for small offsets beyond the tested bounds. Allow some file system imprecision, especially on the wide range of hardware and loads where tests are running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow wider range of file system times in tests
File system times need a wider range of allowed values on two tests. One of the tests fails consistently on OpenBSD, likely due to the precise one second data reporting of OpenBSD file system times and the slow hardware where I'm running it. One of the tests fails less frequently with a small range error. The second test now allows an additional 20% on its range for slow file systems.
Checklist
Types of changes