Skip to content

Resolve deprecations in main#899

Merged
MarkEWaite merged 37 commits intojenkinsci:masterfrom
MarkEWaite:reduce-deprecation-warnings
Jun 5, 2020
Merged

Resolve deprecations in main#899
MarkEWaite merged 37 commits intojenkinsci:masterfrom
MarkEWaite:reduce-deprecation-warnings

Conversation

@MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented May 26, 2020

Resolve Java deprecation messages in main, many in tests

Replace calls to deprecated main methods with their replacement methods or mark the calling method deprecated as appropriate.

Replace calls to several deprecated test methods with their replacement methods or mark the calling method deprecated as appropriate.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Refactoring

Further comments

All the changes are intended to be behavior preserving refactors.

MarkEWaite added 30 commits May 26, 2020 14:13
Silence deprecation warnings
The caller has only built one time in the workspace so "some"
workspace can only be the single build that was run.
Deprecation happened in 1.427, a very long time ago.
@MarkEWaite MarkEWaite force-pushed the reduce-deprecation-warnings branch from c59eb71 to 6863f10 Compare May 30, 2020 20:29
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Jun 4, 2020
@MarkEWaite MarkEWaite force-pushed the reduce-deprecation-warnings branch 2 times, most recently from 3e2304a to 5d3033c Compare June 4, 2020 10:43
@MarkEWaite MarkEWaite force-pushed the reduce-deprecation-warnings branch 4 times, most recently from 3d8d253 to a126b0c Compare June 4, 2020 11:16
Once jenkins-infra/pipeline-library#141 is merged,
the calls to `clean` can be removed.
@MarkEWaite MarkEWaite force-pushed the reduce-deprecation-warnings branch from a126b0c to b279163 Compare June 4, 2020 11:20
@MarkEWaite MarkEWaite merged commit a3d4ec8 into jenkinsci:master Jun 5, 2020
@MarkEWaite MarkEWaite deleted the reduce-deprecation-warnings branch June 5, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Reduces maintenance effort by changes not directly visible to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant