Use Hamcrest instead of deprecated JUnit methods#883
Merged
MarkEWaite merged 3 commits intojenkinsci:masterfrom Apr 20, 2020
Merged
Use Hamcrest instead of deprecated JUnit methods#883MarkEWaite merged 3 commits intojenkinsci:masterfrom
MarkEWaite merged 3 commits intojenkinsci:masterfrom
Conversation
JUnit 4.13 has deprecated Assert.assertThat in favor of the Hamcrest implementation of assertThat. Switch to use the Hamcrest assertThat method instead of the JUnit assertThat method.
MarkEWaite
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Hamcrest instead of deprecated JUnit methods
JUnit 4.13 deprecated the Assert.assertThat method. The Hamcrest assertThat is the replacement for Assert.assertThat. Use the replacement.
JUnit 4.13 deprecated the ExpectedException class. The Assert.assertThrows method is the replacement. Use the replacement.
Checklist
Types of changes