Skip to content

[JENKINS-75311] Add closing quote in checkout scmGit branches example#1723

Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom
ruyut:fix/git-syntax-missing-bracket
Feb 20, 2025
Merged

[JENKINS-75311] Add closing quote in checkout scmGit branches example#1723
MarkEWaite merged 1 commit intojenkinsci:masterfrom
ruyut:fix/git-syntax-missing-bracket

Conversation

@ruyut
Copy link
Contributor

@ruyut ruyut commented Feb 20, 2025

[JENKINS-75311] Fix missing closing quote in checkout scmGit branches argument

Fixed the incorrect checkout scmGit syntax, changing branches: [[name: 'main]] to branches: [[name: 'main']].

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ruyut ruyut requested a review from a team as a code owner February 20, 2025 07:43
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 20, 2025
@MarkEWaite MarkEWaite changed the title [JENKINS-66214] Fix missing closing bracket in checkout scmGit branches argument [JENKINS-75311] Fix missing closing quote in Japanese translated checkout scmGit branches argument Feb 20, 2025
@MarkEWaite MarkEWaite added the bug Incorrect or flawed behavior label Feb 20, 2025
@MarkEWaite MarkEWaite changed the title [JENKINS-75311] Fix missing closing quote in Japanese translated checkout scmGit branches argument [JENKINS-75311] Fix missing closing quote in Japanese checkout scmGit branches example Feb 20, 2025
@MarkEWaite MarkEWaite changed the title [JENKINS-75311] Fix missing closing quote in Japanese checkout scmGit branches example [JENKINS-75311] Add closing quote in Japanese checkout scmGit branches example Feb 20, 2025
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! Nice detection of a bug in the example. The bug was first introduced in 19dcec3 when I updated an example.

@MarkEWaite MarkEWaite changed the title [JENKINS-75311] Add closing quote in Japanese checkout scmGit branches example [JENKINS-75311] Add closing quote in checkout scmGit branches example Feb 20, 2025
@MarkEWaite MarkEWaite merged commit e0b7ea9 into jenkinsci:master Feb 20, 2025
18 checks passed
@MarkEWaite MarkEWaite removed the bug Incorrect or flawed behavior label Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants