Fix acceptance tests by reverting capitalization change#1647
Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom Aug 26, 2024
Merged
Fix acceptance tests by reverting capitalization change#1647MarkEWaite merged 1 commit intojenkinsci:masterfrom
MarkEWaite merged 1 commit intojenkinsci:masterfrom
Conversation
The Jenkins acceptance test harness uses the display name to locate UI components and test them. It locates those components by display name. The tests in the acceptance test harness are especially valuable now while we are preparing for the Spring Security 6.x upgrade. It is better to retain the previous capitalization and preserve Jenkins acceptance test harness results rather than need to spread the capitalization change into the acceptance test harness and related components. Added TODO item to fix the capitalization in both the git plugin and the acceptance test harness in a future release.
MarkEWaite
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix acceptance tests by reverting capitalization change
The Jenkins acceptance test harness uses the display name to locate UI components and test them. It locates those components by display name.
The tests in the acceptance test harness are especially valuable now while we are preparing for the Spring Security 6.x upgrade. It is better to retain the previous capitalization and preserve Jenkins acceptance test harness results rather than need to spread the capitalization change into the acceptance test harness and related components.
Added TODO item to fix the capitalization in both the git plugin and the acceptance test harness in a future release.
Testing done
Confirmed that automated tests pass on Java 21 Linux. Confirmed by review of the acceptance test harness stack trace that the capitalization change is the source of the problem.
Submitter checklist