Skip to content

Test git client, git, and scm API plugins for Jakarta EE 9#3719

Closed
MarkEWaite wants to merge 6 commits intojenkinsci:masterfrom
MarkEWaite:test-git-plugin-and-more
Closed

Test git client, git, and scm API plugins for Jakarta EE 9#3719
MarkEWaite wants to merge 6 commits intojenkinsci:masterfrom
MarkEWaite:test-git-plugin-and-more

Conversation

@MarkEWaite
Copy link
Contributor

Test git client, git, and scm API plugins for Jakarta EE 9

Changes method signatures of several methods in the git plugin from x(StaplerRequest) to x(StaplerRequest2), but hoped that there are no consumers of those API's outside the git plugin.

Testing done

Confirmed that PLUGINS=git,scm-api TEST=InjectedTest bash local-test.sh passes locally.

Rely on ci.jenkins.io to test more broadly.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

* jenkinsci/git-client-plugin#1172
* jenkinsci/git-plugin#1671
* jenkinsci/scm-api-plugin#282

Changes method signatures of several methods in the git plugin from
x(StaplerRequest) to x(StaplerRequest2), but hoped that there are no
consumers of those API's outside the git plugin.
@basil
Copy link
Member

basil commented Oct 10, 2024

Test passed

@basil basil closed this Oct 10, 2024
@MarkEWaite MarkEWaite deleted the test-git-plugin-and-more branch October 10, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants