Skip to content

Test the copy button logic improvement in core#2562

Closed
MarkEWaite wants to merge 3 commits intojenkinsci:masterfrom
MarkEWaite:better-copy-button-logic
Closed

Test the copy button logic improvement in core#2562
MarkEWaite wants to merge 3 commits intojenkinsci:masterfrom
MarkEWaite:better-copy-button-logic

Conversation

@MarkEWaite
Copy link
Contributor

Test the copy button logic improvement in core

HTMLUnit 3 should already be implemented in all the plugins that are included in the bill of materials, but it is better to verify in the plugin bill of materials now than to discover it with a broken build of the plugin BOM at release time.

Checking

Thanks to @D3SOX for the pull request proposing the improvement.

Testing done

Confirmed that mvn --pl sample-plugin verify passes with the incremental build. Rely on ci job for other verification.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

HTMLUnit 3 should already be implemented in all the plugins that are
included in the bill of materials, but it is better to verify in the
plugin bill of materials now than to discover it with a broken build of
the plugin BOM at release time.

Checking

* jenkinsci/jenkins#8554

Thanks to @D3SOX for the pull request proposing the improvement.
@MarkEWaite MarkEWaite added work-in-progress full-test Test all LTS lines in this PR and do not halt upon first error. labels Oct 4, 2023
@MarkEWaite
Copy link
Contributor Author

Jobs executed on the weekly line all passed. Closing and deleting the branch

@MarkEWaite MarkEWaite closed this Oct 5, 2023
@MarkEWaite MarkEWaite deleted the better-copy-button-logic branch October 5, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-test Test all LTS lines in this PR and do not halt upon first error. work-in-progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant