Skip to content

feat: log details of failed github req/res #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jenkins-x-bot merged 1 commit into from
Jul 11, 2025
Merged

feat: log details of failed github req/res #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions scm/driver/github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,15 @@ import (
"encoding/json"
"errors"
"fmt"
"io"
"net/http"
"net/url"
"strconv"
"strings"
"time"

"github.com/sirupsen/logrus"

"github.com/jenkins-x/go-scm/scm"
githubql "github.com/shurcooL/githubv4"
)
Expand Down Expand Up @@ -164,6 +167,18 @@ func (c *wrapper) doRequest(ctx context.Context, req *scm.Request, in, out inter
if res.Status == 404 {
return res, scm.ErrNotFound
}
if logrus.IsLevelEnabled(logrus.DebugLevel) && res.Body != nil {
if b, err := io.ReadAll(res.Body); err == nil {
logrus.WithFields(logrus.Fields{
"requestMethod": req.Method,
"requestPath": req.Path,
"responseStatus": res.Status,
"responseBody": string(b),
"rate": res.Rate,
"requestID": res.ID,
}).Debug("GitHub responded with error")
}
}
return res, errors.New(
http.StatusText(res.Status),
)
Expand Down