feat(package) publish the WAR signature file#830
Merged
Conversation
5 tasks
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
30ce450 to
84be322
Compare
84be322 to
aada25f
Compare
Contributor
Author
|
Removed the debug commit 84be322 (which was testing jenkinsci/packaging#462): ready to review |
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. jenkins-infra/helpdesk#4055
Requires jenkinsci/packaging#462 before being merged
This PR is related to jenkinsci/packaging#462: It changes the
utils/release.bashscript to add the download of the WAR's signature file (generated by Maven during the "release" process) next to the WAR file (same filename with an added suffix.asc).It allows publishing the GPG signature of the WAR file along with the GPG key used to sign the WAR during the Maven release process.
Validations (run with jenkinsci/packaging@c8f0063):
Note: I've tried to add a verification of the downloaded WAR initially but I had to solve the case of "current LTS uses an old GPG key" which is an edge case. So I've removed the verification from this PR and we'll add it back after 2.541.1