Skip to content

zxcm#8270

Closed
louismanhnguyen1998 wants to merge 8 commits intojenkins-infra:masterfrom
louismanhnguyen1998:master
Closed

zxcm#8270
louismanhnguyen1998 wants to merge 8 commits intojenkins-infra:masterfrom
louismanhnguyen1998:master

Conversation

@louismanhnguyen1998
Copy link

This pull request introduces new workflows for code analysis and JavaScript protection, as well as a security policy document. The most significant changes include the addition of a CodeQL workflow for advanced code scanning, a Jscrambler workflow for JavaScript code integrity, and a SECURITY.md file outlining the project's security policy.

New Workflows for Code Analysis and Protection:

  • CodeQL Workflow: Added a .github/workflows/codeql.yml file to enable advanced CodeQL analysis for JavaScript/TypeScript and Ruby. This includes scheduled scans, support for multiple languages, and customizable build modes.
  • Jscrambler Workflow: Added a .github/workflows/jscrambler-code-integrity.yml file to automate the protection of JavaScript applications using Jscrambler. This workflow integrates with Jscrambler's service and requires account credentials.

Security Policy:

  • SECURITY.md File: Introduced a SECURITY.md file to define the supported versions of the project and provide guidelines for reporting vulnerabilities.

CodexRaunak and others added 8 commits June 10, 2025 15:42
* Fix the missing directory for birajit community bonding blog post

* Add blog post for community bonding period - Raunak Madan

* Apply suggestions from code review

Co-authored-by: Kevin Martens <99040580+kmartens27@users.noreply.github.com>

* Update TOC

---------

Co-authored-by: Kris Stern <krisstern@outlook.com>
Co-authored-by: Kevin Martens <99040580+kmartens27@users.noreply.github.com>
…jenkinsfile-to-check-broken-links

Revert "Run broken link checks during CI"
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces security and code integrity workflows along with a security policy document. The changes establish automated code analysis and JavaScript protection capabilities for the project.

  • Addition of CodeQL workflow for automated security scanning of JavaScript/TypeScript and Ruby code
  • Integration of Jscrambler workflow for JavaScript code protection and obfuscation
  • Creation of security policy document to define supported versions and vulnerability reporting procedures

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
SECURITY.md Adds security policy template with version support matrix and vulnerability reporting guidelines
.github/workflows/codeql.yml Implements CodeQL advanced security scanning for JavaScript/TypeScript and Ruby languages
.github/workflows/jscrambler-code-integrity.yml Adds JavaScript code protection workflow using Jscrambler service

Comment on lines +5 to +6
Use this section to tell people about which versions of your project are
currently being supported with security updates.
Copy link

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SECURITY.md file contains placeholder text that should be customized for this specific project. The generic instructions should be replaced with actual project-specific information about supported versions and vulnerability reporting procedures.

Suggested change
Use this section to tell people about which versions of your project are
currently being supported with security updates.
The following table lists the versions of this project that are currently
supported with security updates. Please ensure you are using a supported version.

Copilot uses AI. Check for mistakes.
Comment on lines +17 to +21
Use this section to tell people how to report a vulnerability.

Tell them where to go, how often they can expect to get an update on a
reported vulnerability, what to expect if the vulnerability is accepted or
declined, etc.
Copy link

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vulnerability reporting section contains placeholder text instead of actual reporting instructions. This should include specific contact information, expected response times, and the vulnerability disclosure process.

Suggested change
Use this section to tell people how to report a vulnerability.
Tell them where to go, how often they can expect to get an update on a
reported vulnerability, what to expect if the vulnerability is accepted or
declined, etc.
If you discover a vulnerability in this project, please report it by emailing us at security@example.com.
Include as much detail as possible, such as steps to reproduce the issue, the potential impact, and any suggested fixes.
**Expected Response Times:**
- Initial acknowledgment: Within 2 business days.
- Progress updates: Every 5 business days until the issue is resolved.
**Disclosure Process:**
- Once a vulnerability is reported, our security team will assess its severity and validity.
- If the vulnerability is confirmed, we will work on a fix and notify you when it is resolved.
- We request that you do not publicly disclose the vulnerability until we have released a fix and informed all affected users.

Copilot uses AI. Check for mistakes.

This comment was marked as spam.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@krisstern krisstern requested a review from daniel-beck July 16, 2025 11:00
@krisstern
Copy link
Member

May I ask why is this change needed and has there been any discussion with the Jenkins Security team prior to the creation of this PR?

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spam pull request. Please ban the spammer @louismanhnguyen1998 from the jenkins-infra organization so that we don't waste more time with spam pull requests

@MarkEWaite MarkEWaite closed this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants