RecursionError: maximum recursion depth exceeded

[ericwb]

I tested out vulture on a project I maintain (Bandit). Unfortunately, the first result I got was a RecursionError. It's not clear to me if this is by-design or an edge case bug. Bandit itself does static analysis using an AST and vulture seems to trip up when inspecting the visitor logic.

To reproduce:

pip install vulture
git clone https://github.com/PyCQA/bandit
cd bandit
vulture .

  File "/Users/ericwb/workspace/reflex-web/venv/lib/python3.12/site-packages/vulture/core.py", line 721, in generic_visit
    self.visit(value)
  File "/Users/ericwb/workspace/reflex-web/venv/lib/python3.12/site-packages/vulture/core.py", line 687, in visit
    return self.generic_visit(node)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ericwb/workspace/reflex-web/venv/lib/python3.12/site-packages/vulture/core.py", line 721, in generic_visit
    self.visit(value)
  File "/Users/ericwb/workspace/reflex-web/venv/lib/python3.12/site-packages/vulture/core.py", line 672, in visit
    visitor(node)
  File "/Users/ericwb/workspace/reflex-web/venv/lib/python3.12/site-packages/vulture/core.py", line 521, in visit_BinOp
    utils.is_ast_string(node.left)
RecursionError: maximum recursion depth exceeded

[jendrikseipp]

Thanks for the report! This is definitely not by design. Happy to review a PR if you take the time to tackle this.

[ericwb]

Looks like this isn't occurring on Bandit source code, but one of its dependencies in the .tox directory.

Narrowing it down some, it occurs here:
vulture .tox/py312/lib/python3.12/site-packages/astroid

[ericwb]

More specifically, it's this file:
vulture bandit/.tox/py312/lib/python3.12/site-packages/astroid/tests/testdata/python3/data/joined_strings.py

[ericwb]

Here's a reference issue in astroid. So this might be an extreme edge case that doesn't need fixing. However, it would be nice if the RecursionError was caught and handled gracefully in vulture.

pylint-dev/astroid#557

[jendrikseipp]

Thanks for looking into this! Can you make a pull request along those lines?

[matthewpwatkins]

I just ran into this recursion error, too. Ping-ponging back and forth:

...
File "/home/ec2-user/dev/atb-processing-service/.venv/lib/python3.12/site-packages/vulture/core.py", line 663, in generic_visit
    self.visit(value)
  File "/home/ec2-user/dev/atb-processing-service/.venv/lib/python3.12/site-packages/vulture/core.py", line 629, in visit
    self.generic_visit(node)
  File "/home/ec2-user/dev/atb-processing-service/.venv/lib/python3.12/site-packages/vulture/core.py", line 663, in generic_visit
    self.visit(value)
  File "/home/ec2-user/dev/atb-processing-service/.venv/lib/python3.12/site-packages/vulture/core.py", line 629, in visit
    self.generic_visit(node)
  File "/home/ec2-user/dev/atb-processing-service/.venv/lib/python3.12/site-packages/vulture/core.py", line 663, in generic_visit
    self.visit(value)
  File "/home/ec2-user/dev/atb-processing-service/.venv/lib/python3.12/site-packages/vulture/core.py", line 629, in visit
    self.generic_visit(node)
  File "/home/ec2-user/dev/atb-processing-service/.venv/lib/python3.12/site-packages/vulture/core.py", line 657, in generic_visit
    for _, value in ast.iter_fields(node):
                    ^^^^^^^^^^^^^^^^^^^^^
RecursionError: maximum recursion depth exceeded

[jendrikseipp]

Thanks for the report! Can you past the code that triggers this issue here?

[canadiancreed]

Still getting this error on latest version. No hint as to the exact code that's causing it

[jendrikseipp]

Can you please check if the error still occurs when using the code from #401 ?