Skip to content

Implement Password Modify Extended Operation#172

Merged
crobibero merged 1 commit into
jellyfin:masterfrom
Zeault:passmod
Jan 11, 2025
Merged

Implement Password Modify Extended Operation#172
crobibero merged 1 commit into
jellyfin:masterfrom
Zeault:passmod

Conversation

@Zeault

@Zeault Zeault commented Dec 20, 2024

Copy link
Copy Markdown
Contributor

I implemented the LDAP Password Modify Extended Operation. Completes #127 and #143.

@Zeault

Zeault commented Dec 20, 2024

Copy link
Copy Markdown
Contributor Author

I did not add any new configuration options for this feature. Instead, the change password code will now check to see if the extended operation is supported by the server and use it automatically.

This works seamlessly on OpenLDAP because my tests have shown that a user that has permission to write a password will necessarily have permission to change it with the extended operation. However, on other LDAP servers it is possible that this breaks someone's working configuration. It all depends on how the server handles permissions.

@Zeault Zeault marked this pull request as ready for review December 22, 2024 03:11
@crobibero crobibero merged commit 1ef7932 into jellyfin:master Jan 11, 2025
@crobibero crobibero added the feature This PR or Issue requests or introduces a new feature label Jan 11, 2025
@Zeault Zeault deleted the passmod branch January 12, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature This PR or Issue requests or introduces a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants