Make Cache.Get allocation-free#162
Merged
davseby merged 3 commits intojellydator:v3from Feb 6, 2025
Merged
Conversation
davseby
reviewed
Jan 8, 2025
Contributor
davseby
left a comment
davseby
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
Changed applyOptions and the Option[K,V] to be non-allocating by avoiding pointers Added the Test_Get_DoesNotAllocate to make sure that Get does not allocate (it fails before this commit)
yiftachkarkason
force-pushed
the
non-allocations-options
branch
from
2614d4e to
826a563
Compare
swithek
reviewed
Jan 9, 2025
Contributor
swithek
left a comment
swithek
left a comment
There was a problem hiding this comment.
I think we can merge this? @davseby
Well done @yiftachkarkason
davseby
reviewed
Jan 10, 2025
Pull Request Test Coverage Report for Build 13180247307Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
We encountered a performance issue when we heavily used the Cache, and narrowed it down to the allocation made by
Cache.Getas part of the options processing.Thank you for the great package!