-
Notifications
You must be signed in to change notification settings - Fork 280
Fix icons svg #3331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icons svg #3331
Conversation
Walkthrough在 package.json 中将依赖 @nutui/icons-react-taro 的版本从 ^3.0.2-beta.2 更新为 ^3.0.2-beta.3。无其他文件或导出声明变更。 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 分钟 Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3331 +/- ##
==========================================
Coverage 88.13% 88.13%
==========================================
Files 291 291
Lines 19140 19140
Branches 2971 2971
==========================================
Hits 16869 16869
Misses 2266 2266
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
112-112
: 处于 beta 阶段的依赖建议固定精确版本,避免 caret 带来的不可预期升级使用 ^ 对预发布版本(beta)可能在安装时解析到更高的 beta 版本,造成 CI/下游环境行为不一致。为提高可控性,建议在 beta 阶段固定到精确版本。
可选修改如下:
- "@nutui/icons-react-taro": "^3.0.2-beta.3", + "@nutui/icons-react-taro": "3.0.2-beta.3",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test
- GitHub Check: build
🔇 Additional comments (1)
package.json (1)
112-112
: 升级 @nutui/icons-react-taro 到 ^3.0.2-beta.3:npm 已发布且锁文件已包含该版本,请验证接口兼容性与安装测试已核实(简要):
- npm registry 可解析 @nutui/[email protected](已发布)。
- package.json 中已将依赖更新为:
"@nutui/icons-react": "^3.0.2-beta.5", "@nutui/icons-react-taro": "^3.0.2-beta.3",
- pnpm-lock.yaml 包含 '@nutui/[email protected]' 条目(锁文件已同步)。
- 代码库大量文件按名从该包导入(示例:src/packages/address/address.taro.tsx、src/packages/popover/popover.taro.tsx、src/packages/icon/doc.taro.md 等)。
需要关注 / 建议的后续操作:
- 请在合并前在本地或 CI 运行安装并检查:pnpm i(或相应包管理器) + pnpm run checked:taro,确认能成功安装并通过类型检查。
- 重点手动/自动验证关键页面或 demo(taro/h5)上的图标渲染是否正常,确认无导出重命名或缺失导致的运行时报错。
- 如果希望,我可以补充自动化兼容性检查脚本(对比发布包的 types/导出名与仓库中实际按名导入项),来确认是否存在破坏性变更。
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit