Skip to content

Fix icons svg #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2025
Merged

Fix icons svg #3331

merged 4 commits into from
Aug 15, 2025

Conversation

xiaoyatong
Copy link
Collaborator

@xiaoyatong xiaoyatong commented Aug 15, 2025

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • Chores
    • 更新依赖 @nutui/icons-react-taro 至 v3.0.2-beta.3,获取上游图标优化与修复,提升稳定性与兼容性。
    • 本次为维护性更新,无需用户操作,现有功能与界面行为保持不变。

Copy link

coderabbitai bot commented Aug 15, 2025

Walkthrough

在 package.json 中将依赖 @nutui/icons-react-taro 的版本从 ^3.0.2-beta.2 更新为 ^3.0.2-beta.3。无其他文件或导出声明变更。

Changes

Cohort / File(s) Change Summary
依赖版本更新
package.json
将依赖 @nutui/icons-react-taro 版本由 ^3.0.2-beta.2 升级至 ^3.0.2-beta.3

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 分钟

Possibly related PRs

Suggested reviewers

  • Alex-huxiyang
  • Miles-hxy

Poem

小兔挥爪点版本,🔧
icons 轻跃到 beta.3。
package 一行风吹过,
枝头新叶更清晰。
我在依赖林里蹦,
为你递上最新的希冀。 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added 3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) labels Aug 15, 2025
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.13%. Comparing base (2d0aa82) to head (3fd6c9c).
⚠️ Report is 1 commits behind head on feat_v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat_v3.x    #3331   +/-   ##
==========================================
  Coverage      88.13%   88.13%           
==========================================
  Files            291      291           
  Lines          19140    19140           
  Branches        2971     2971           
==========================================
  Hits           16869    16869           
  Misses          2266     2266           
  Partials           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

112-112: 处于 beta 阶段的依赖建议固定精确版本,避免 caret 带来的不可预期升级

使用 ^ 对预发布版本(beta)可能在安装时解析到更高的 beta 版本,造成 CI/下游环境行为不一致。为提高可控性,建议在 beta 阶段固定到精确版本。

可选修改如下:

-    "@nutui/icons-react-taro": "^3.0.2-beta.3",
+    "@nutui/icons-react-taro": "3.0.2-beta.3",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2d0aa82 and 3fd6c9c.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test
  • GitHub Check: build
🔇 Additional comments (1)
package.json (1)

112-112: 升级 @nutui/icons-react-taro 到 ^3.0.2-beta.3:npm 已发布且锁文件已包含该版本,请验证接口兼容性与安装测试

已核实(简要):

  • npm registry 可解析 @nutui/[email protected](已发布)。
  • package.json 中已将依赖更新为:
"@nutui/icons-react": "^3.0.2-beta.5",
"@nutui/icons-react-taro": "^3.0.2-beta.3",
  • pnpm-lock.yaml 包含 '@nutui/[email protected]' 条目(锁文件已同步)。
  • 代码库大量文件按名从该包导入(示例:src/packages/address/address.taro.tsx、src/packages/popover/popover.taro.tsx、src/packages/icon/doc.taro.md 等)。

需要关注 / 建议的后续操作:

  • 请在合并前在本地或 CI 运行安装并检查:pnpm i(或相应包管理器) + pnpm run checked:taro,确认能成功安装并通过类型检查。
  • 重点手动/自动验证关键页面或 demo(taro/h5)上的图标渲染是否正常,确认无导出重命名或缺失导致的运行时报错。
  • 如果希望,我可以补充自动化兼容性检查脚本(对比发布包的 types/导出名与仓库中实际按名导入项),来确认是否存在破坏性变更。

@xiaoyatong xiaoyatong merged commit 6f80776 into jdf2e:feat_v3.x Aug 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant