-
Notifications
You must be signed in to change notification settings - Fork 280
feat(notify): 支持promise调用notice #3319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthrough本次更改将 Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant NotifyModule
participant getInstance
Caller->>NotifyModule: notice(opts)
activate NotifyModule
NotifyModule->>getInstance: getInstance(callback)
getInstance-->>NotifyModule: 通知实例创建
NotifyModule-->>Caller: Promise resolved
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings
🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3319 +/- ##
==========================================
Coverage 88.13% 88.14%
==========================================
Files 290 290
Lines 19110 19113 +3
Branches 2959 2961 +2
==========================================
+ Hits 16843 16847 +4
+ Misses 2262 2261 -1
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤔 这个变动的性质是?
🔗 相关 Issue
#3312
💡 需求背景和解决方案
修复Notify.hide时序问题
☑️ 请求合并前的自查清单
Summary by CodeRabbit