-
Notifications
You must be signed in to change notification settings - Fork 280
fix: taro default import error #3057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthrough本次 PR 调整了代码中对 Taro 库的引入方式。在 Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3057 +/- ##
==========================================
Coverage 86.06% 86.06%
==========================================
Files 275 275
Lines 18234 18234
Branches 2751 2751
==========================================
Hits 15694 15694
Misses 2535 2535
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
return Taro.canIUse('getDeviceInfo') | ||
? Taro.getDeviceInfo() | ||
: Taro.getSystemInfoSync() | ||
return canIUse('getDeviceInfo') ? taroGetDeviceInfo() : getSystemInfoSync() | ||
} | ||
|
||
/** | ||
* 获取窗口信息,兼容新旧 API | ||
* @returns {Taro.getWindowInfo.Result} 窗口信息 | ||
*/ | ||
export const getWindowInfo = (): Taro.getWindowInfo.Result => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件里是不是都用taroGetxxx就行了,不需要引入Taro了
Summary by CodeRabbit