Skip to content

fix: corepack manager use pnpm failed #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 64 commits into from

Conversation

Miles-hxy
Copy link
Collaborator

@Miles-hxy Miles-hxy commented Feb 5, 2025

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • Chores
    • 优化了持续集成流程中依赖管理工具的安装步骤,确保各关键任务准确使用预期版本。
    • 调整了安装命令,提升了构建、测试及代码质量检查的稳定性和一致性。

xiaoyatong and others added 30 commits October 30, 2024 10:29
* fix(avatarcropper): 多语言支持

* fix: fix test error
…e#2675)

* test: add unit testing

* chore: revert lock

* fix:  indexof 进行路径匹配可能会导致
* fix: tabs should show left edge

* fix: update lock to fix ci insatall failed

* fix: ci failed

* fix: ci failed

* fix: build

* fix: build
* chore: use pull request target event

* chore: use pull request target event

* chore: use pull request target event

* chore: use pull request target event

* chore: use pull request target event

* chore: use pull request target event

* chore: ci test

* chore: ci test

* chore: ci test

* chore: ci test

* chore: ci test

* chore: ci test

* chore: ci test

* chore: ci test

* chore: ci test

* chore: ci test
* chore: ci optimize

* fix: delete useles

* fix: delete useles
* fix(Form): Form 组件文档 demo 中 Switch 组件使用问题

* fix: test error

---------

Co-authored-by: oasis-cloud <[email protected]>
* docs(infiniteLoading): optimize target description

* docs(infiniteLoading): optimize target description
…e#2773)

* fix(popup): display should not trigger the scrollview to update

* fix: test error
* fix: 给个默认背景色,解决在小程序中固定列与滚动内列混合

* fix(Table): 给个默认背景色,解决在小程序中固定列与滚动内列混合
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- 修复了 readFile 方法中多文件处理的缺陷
- 调整文件读取逻辑,确保所有选中的文件都能正确处理
* feat(form): add validateTrigger, setFieldValue and disabled

* feat(form): add validateTrigger, setFieldValue and disabled

* feat(form): add validateTrigger, setFieldValue and disabled

* fix: ci error

* fix: ai's review

* fix: add required

* docs: update

---------

Co-authored-by: Alex.hxy <[email protected]>
Miles-hxy and others added 22 commits December 30, 2024 16:37
* feat: suppport chooseMedia in web

* feat: suppport chooseMedia in web
* feat: getRectByTaro 方法在小程序内增加缓存以提升性能

* feat: lock 文件提交

* feat: 工具类新增 lru

* feat:  增加capacity 参数值校验

* feat: lock 文件还原
* fix: 调整日历日期

* fix: 京东小程序ide问题
* feat(form): add useWatch

* fix: build error

* test: update case

* fix(form): 修复 review 意见;以及修复了 registerField 后,在组件销毁时应该回复默认值。

* fix(form): 修复 review 意见;以及修复了 registerField 后,在组件销毁时应该回复默认值。

* fix: reviews
* fix(form): formitem 的值如果是对象会自动重置为空对象

* fix(form): formitem 的值如果是对象会自动重置为空对象

* test: 增加单测

* test: 增加单测

* fix: reviews

* fix: reviews
* feat(form): resetFields 增加 namepath 参数,用于重置指定的字段

* fix: reviews

* fix: reviews
* fix: 受控模式下返回的selectedOptions进行校验处理

* fix: added the datehour judgment
* fix: tabs 代码简化,调整部分样式

* test: tabs address and cascader
Copy link

coderabbitai bot commented Feb 5, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

121 files out of 203 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

该 PR 修改了 GitHub Actions 工作流中 pnpm 的安装步骤。在 .github/workflows/ci.yml.github/workflows/sync-taro.yml 中,将旧的单行命令替换为多行命令,先启用 corepack,再激活指定版本的 pnpm(分别为 9.15.2 和 10.0.0)。而在 .github/workflows/sync-migrate.yml 中,安装方式由 corepack enable pnpm 修改为 npm i -g pnpm。工作流的整体结构和其他步骤保持不变。

Changes

文件 变更摘要
.github/workflows/ci.yml
.github/workflows/sync-taro.yml
将单行启用 pnpm 命令替换为多行命令:先启用 corepack,再激活指定版本的 pnpm(分别为 9.15.2 和 10.0.0)。
.github/workflows/sync-migrate.yml 修改安装命令,由 corepack enable pnpm 改为 npm i -g pnpm

Possibly related PRs

Suggested reviewers

  • oasis-cloud

Poem

我是一只跳跃的小兔,
代码花园中步步精雕细琢,
pnpm 的新指令闪耀如星,
旧命令随风而去,新意迎面而来。
在 CI 的舞台上欢快奔跑,
与代码共舞,跃向光明的明天! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 3.x Target branch 3.x label Feb 5, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 95c21a7 and 3e4256a.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml (2 hunks)
  • .github/workflows/sync-migrate.yml (1 hunks)
  • .github/workflows/sync-taro.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/ci.yml

20-20: could not parse as YAML: yaml: line 20: could not find expected ':'

(syntax-check)

.github/workflows/sync-taro.yml

21-21: could not parse as YAML: yaml: line 21: could not find expected ':'

(syntax-check)

🪛 YAMLlint (1.35.1)
.github/workflows/ci.yml

[error] 21-21: syntax error: could not find expected ':'

(syntax)

.github/workflows/sync-taro.yml

[error] 22-22: syntax error: could not find expected ':'

(syntax)

🔇 Additional comments (1)
.github/workflows/sync-migrate.yml (1)

20-21: 更新 pnpm 安装命令
本次修改将原有的 corepack enable pnpm 替换为 npm i -g pnpm。这种修改符合 PR 目标,但请确认整个项目中关于 pnpm 的安装方式是否需要统一,以避免不同工作流之间因依赖管理方式不一致而引起潜在问题。

Comment on lines 20 to 22
run: |
corepack enable
corepack prepare [email protected] --activate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

多行命令缩进问题
在 YAML 文件中使用多行命令(run: |)时,后续命令行需要比 run: 键增加额外缩进(通常为两个空格),否则会导致 YAML 解析错误。请将第 21 行和第 22 行增加适当缩进。例如:

-        run: |
-        corepack enable
-        corepack prepare [email protected] --activate
+        run: |
+          corepack enable
+          corepack prepare [email protected] --activate
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run: |
corepack enable
corepack prepare [email protected] --activate
run: |
corepack enable
corepack prepare [email protected] --activate
🧰 Tools
🪛 actionlint (1.7.4)

21-21: could not parse as YAML: yaml: line 21: could not find expected ':'

(syntax-check)

🪛 YAMLlint (1.35.1)

[error] 22-22: syntax error: could not find expected ':'

(syntax)

Comment on lines 40 to 42
run: |
corepack enable
corepack prepare [email protected] --activate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

YAML 多行命令缩进错误(Test Job)
与 lint job 类似,test job 中的多行命令块也存在缩进问题。请调整为正确的缩进格式,确保每一行命令均比 run: 关键字多两个空格:

-        run: |
-        corepack enable
-        corepack prepare [email protected] --activate
+        run: |
+          corepack enable
+          corepack prepare [email protected] --activate
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run: |
corepack enable
corepack prepare [email protected] --activate
run: |
corepack enable
corepack prepare [email protected] --activate

Comment on lines 19 to 21
run: |
corepack enable
corepack prepare [email protected] --activate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

YAML 多行命令缩进错误(Lint Job)
在 lint job 中用于安装 pnpm 的多行命令缩进不当,导致 YAML 解析错误。请为 corepack enable 及后续命令增加额外缩进,以确保格式正确,如下示例所示:

-        run: |
-        corepack enable
-        corepack prepare [email protected] --activate
+        run: |
+          corepack enable
+          corepack prepare [email protected] --activate
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run: |
corepack enable
corepack prepare [email protected] --activate
run: |
corepack enable
corepack prepare [email protected] --activate
🧰 Tools
🪛 actionlint (1.7.4)

20-20: could not parse as YAML: yaml: line 20: could not find expected ':'

(syntax-check)

🪛 YAMLlint (1.35.1)

[error] 21-21: syntax error: could not find expected ':'

(syntax)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Target branch 3.x size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.