-
Notifications
You must be signed in to change notification settings - Fork 280
fix: corepack manager use pnpm failed #2964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* fix(avatarcropper): 多语言支持 * fix: fix test error
…e#2675) * test: add unit testing * chore: revert lock * fix: indexof 进行路径匹配可能会导致
* fix: tabs should show left edge * fix: update lock to fix ci insatall failed * fix: ci failed * fix: ci failed * fix: build * fix: build
* chore: use pull request target event * chore: use pull request target event * chore: use pull request target event * chore: use pull request target event * chore: use pull request target event * chore: use pull request target event * chore: ci test * chore: ci test * chore: ci test * chore: ci test * chore: ci test * chore: ci test * chore: ci test * chore: ci test * chore: ci test * chore: ci test
* chore: ci optimize * fix: delete useles * fix: delete useles
* fix(Form): Form 组件文档 demo 中 Switch 组件使用问题 * fix: test error --------- Co-authored-by: oasis-cloud <[email protected]>
* docs(infiniteLoading): optimize target description * docs(infiniteLoading): optimize target description
…e#2773) * fix(popup): display should not trigger the scrollview to update * fix: test error
* fix: 给个默认背景色,解决在小程序中固定列与滚动内列混合 * fix(Table): 给个默认背景色,解决在小程序中固定列与滚动内列混合
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- 修复了 readFile 方法中多文件处理的缺陷 - 调整文件读取逻辑,确保所有选中的文件都能正确处理
* feat(form): add validateTrigger, setFieldValue and disabled * feat(form): add validateTrigger, setFieldValue and disabled * feat(form): add validateTrigger, setFieldValue and disabled * fix: ci error * fix: ai's review * fix: add required * docs: update --------- Co-authored-by: Alex.hxy <[email protected]>
* feat: suppport chooseMedia in web * feat: suppport chooseMedia in web
* feat: getRectByTaro 方法在小程序内增加缓存以提升性能 * feat: lock 文件提交 * feat: 工具类新增 lru * feat: 增加capacity 参数值校验 * feat: lock 文件还原
* fix: 调整日历日期 * fix: 京东小程序ide问题
* feat(form): add useWatch * fix: build error * test: update case * fix(form): 修复 review 意见;以及修复了 registerField 后,在组件销毁时应该回复默认值。 * fix(form): 修复 review 意见;以及修复了 registerField 后,在组件销毁时应该回复默认值。 * fix: reviews
* fix(form): formitem 的值如果是对象会自动重置为空对象 * fix(form): formitem 的值如果是对象会自动重置为空对象 * test: 增加单测 * test: 增加单测 * fix: reviews * fix: reviews
* feat(form): resetFields 增加 namepath 参数,用于重置指定的字段 * fix: reviews * fix: reviews
* fix: 受控模式下返回的selectedOptions进行校验处理 * fix: added the datehour judgment
* fix: tabs 代码简化,调整部分样式 * test: tabs address and cascader
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 121 files out of 203 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Walkthrough该 PR 修改了 GitHub Actions 工作流中 pnpm 的安装步骤。在 Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/ci.yml
(2 hunks).github/workflows/sync-migrate.yml
(1 hunks).github/workflows/sync-taro.yml
(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/ci.yml
20-20: could not parse as YAML: yaml: line 20: could not find expected ':'
(syntax-check)
.github/workflows/sync-taro.yml
21-21: could not parse as YAML: yaml: line 21: could not find expected ':'
(syntax-check)
🪛 YAMLlint (1.35.1)
.github/workflows/ci.yml
[error] 21-21: syntax error: could not find expected ':'
(syntax)
.github/workflows/sync-taro.yml
[error] 22-22: syntax error: could not find expected ':'
(syntax)
🔇 Additional comments (1)
.github/workflows/sync-migrate.yml (1)
20-21
: 更新 pnpm 安装命令
本次修改将原有的corepack enable pnpm
替换为npm i -g pnpm
。这种修改符合 PR 目标,但请确认整个项目中关于 pnpm 的安装方式是否需要统一,以避免不同工作流之间因依赖管理方式不一致而引起潜在问题。
.github/workflows/sync-taro.yml
Outdated
run: | | ||
corepack enable | ||
corepack prepare [email protected] --activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多行命令缩进问题
在 YAML 文件中使用多行命令(run: |
)时,后续命令行需要比 run:
键增加额外缩进(通常为两个空格),否则会导致 YAML 解析错误。请将第 21 行和第 22 行增加适当缩进。例如:
- run: |
- corepack enable
- corepack prepare [email protected] --activate
+ run: |
+ corepack enable
+ corepack prepare [email protected] --activate
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
run: | | |
corepack enable | |
corepack prepare [email protected] --activate | |
run: | | |
corepack enable | |
corepack prepare [email protected] --activate |
🧰 Tools
🪛 actionlint (1.7.4)
21-21: could not parse as YAML: yaml: line 21: could not find expected ':'
(syntax-check)
🪛 YAMLlint (1.35.1)
[error] 22-22: syntax error: could not find expected ':'
(syntax)
.github/workflows/ci.yml
Outdated
run: | | ||
corepack enable | ||
corepack prepare [email protected] --activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAML 多行命令缩进错误(Test Job)
与 lint job 类似,test job 中的多行命令块也存在缩进问题。请调整为正确的缩进格式,确保每一行命令均比 run:
关键字多两个空格:
- run: |
- corepack enable
- corepack prepare [email protected] --activate
+ run: |
+ corepack enable
+ corepack prepare [email protected] --activate
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
run: | | |
corepack enable | |
corepack prepare [email protected] --activate | |
run: | | |
corepack enable | |
corepack prepare [email protected] --activate |
.github/workflows/ci.yml
Outdated
run: | | ||
corepack enable | ||
corepack prepare [email protected] --activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAML 多行命令缩进错误(Lint Job)
在 lint job 中用于安装 pnpm 的多行命令缩进不当,导致 YAML 解析错误。请为 corepack enable
及后续命令增加额外缩进,以确保格式正确,如下示例所示:
- run: |
- corepack enable
- corepack prepare [email protected] --activate
+ run: |
+ corepack enable
+ corepack prepare [email protected] --activate
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
run: | | |
corepack enable | |
corepack prepare [email protected] --activate | |
run: | | |
corepack enable | |
corepack prepare [email protected] --activate |
🧰 Tools
🪛 actionlint (1.7.4)
20-20: could not parse as YAML: yaml: line 20: could not find expected ':'
(syntax-check)
🪛 YAMLlint (1.35.1)
[error] 21-21: syntax error: could not find expected ':'
(syntax)
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit