-
Notifications
You must be signed in to change notification settings - Fork 280
feat(radio): v15 #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radio): v15 #2879
Conversation
变更概述演练此次拉取请求主要涉及两个文件的更改: 变更
可能相关的 PR
建议标签
建议审阅者
诗歌
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #2879 +/- ##
==========================================
Coverage 84.56% 84.56%
==========================================
Files 273 273
Lines 18593 18593
Branches 2691 2691
==========================================
Hits 15723 15723
Misses 2865 2865
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/packages/radio/radio.scss (1)
47-47
: 在禁用状态下移除 box-shadow 的做法可行。
但如需在禁用状态保留其它视觉线索,可考虑减弱 box-shadow 或以其它替代效果,提升可用性。src/config.json (1)
744-744
: Badge 组件版本更新至 v15 与其他组件版本提升保持统一。
建议在更新日志中添加对应说明,确保使用者了解变更内容。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/config.json
(2 hunks)src/packages/radio/radio.scss
(1 hunks)
🔇 Additional comments (1)
src/config.json (1)
613-613
: 版本标记 v15 与用户 PR 标题一致。
确保与 Radio 组件相关的文档及 Demo 同步更新,引导用户了解新增样式或功能。
box-shadow: 0px 2px 4px 0px #ff0f2333; | ||
border-radius: 50%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
建议使用 rgba() 格式替代 #RRGGBBAA 格式的颜色值
在项目中发现了两处使用 #RRGGBBAA 格式的颜色值:
- src/packages/radio/radio.scss:
#ff0f2333
- src/packages/popover/popover.scss:
#3232331f
建议改为使用更广泛支持的 rgba() 格式,以提高兼容性。可参考项目中大量使用的 rgba() 写法,如:
- 对应的透明度 0.2 (33/255) 可写为:
rgba(255, 15, 35, 0.2)
- 对应的透明度 0.12 (1f/255) 可写为:
rgba(50, 50, 51, 0.12)
🔗 Analysis chain
建议检查颜色值的透明度表达方式。
“#ff0f2333” 的格式为 #RRGGBBAA,可能部分编译器或旧的 CSS 语法无法正常解析,也可考虑使用 RGBA。
以下脚本可协助搜索项目内其他类似用法并确认兼容性:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# 在整个仓库搜索 “#RRGGBBAA” 格式的用法
rg --color=never "#[0-9A-Fa-f]\{8\}" -A 2
Length of output: 43
Script:
#!/bin/bash
# 修正正则表达式语法,搜索8位十六进制颜色值
rg --color=never "#[0-9A-Fa-f]{8}" -A 2
# 同时搜索其他透明度表达方式
rg --color=never "rgba?\(" -A 2
Length of output: 70757
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
新特性
v15
,包括Badge
、Radio
、Rate
、Switch
、Toast
、Empty
、ResultPage
、CountDown
、Pagination
和Segmented
。样式
.nut-radio-icon
类添加新的样式,增强选中状态的视觉效果,包括box-shadow
和border-radius
,并为禁用状态设置无阴影效果。