-
Notifications
You must be signed in to change notification settings - Fork 280
feat(form): add validateTrigger, setFieldValue and disabled #2772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
de14e46
feat(form): add validateTrigger, setFieldValue and disabled
oasis-cloud 6ee015e
feat(form): add validateTrigger, setFieldValue and disabled
oasis-cloud 28237a8
Merge branch 'next' into fix/form-issues
oasis-cloud a176a98
feat(form): add validateTrigger, setFieldValue and disabled
oasis-cloud a7a615f
Merge branch 'next' into fix/form-issues
oasis-cloud aa5666c
Merge branch 'next' into fix/form-issues
oasis-cloud c77223c
fix: ci error
oasis-cloud bc8a8aa
fix: ai's review
oasis-cloud cba87ec
Merge branch 'next' into fix/form-issues
oasis-cloud 41da784
fix: add required
oasis-cloud 31f58fb
Merge branch 'next' into fix/form-issues
Miles-hxy bc46d9d
docs: update
oasis-cloud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,71 +1,3 @@ | ||
@import '../cellgroup/cellgroup.scss'; | ||
@import '../cell/cell.scss'; | ||
@import '../formitem/formitem.scss'; | ||
|
||
.form-layout-right .nut-form-item-label { | ||
text-align: right; | ||
padding-right: 24px; | ||
white-space: nowrap; | ||
} | ||
|
||
.form-layout-left .nut-form-item-label { | ||
position: relative; | ||
text-align: left; | ||
padding-left: 12px; | ||
white-space: nowrap; | ||
|
||
.required { | ||
display: block; | ||
line-height: 1.5; | ||
position: absolute; | ||
left: 0.1em; | ||
} | ||
} | ||
|
||
.form-layout-top .nut-form-item { | ||
flex-direction: column; | ||
align-items: flex-start; | ||
white-space: nowrap; | ||
} | ||
|
||
.form-layout-top .nut-form-item-label { | ||
padding-bottom: 4px; | ||
display: block; | ||
padding-right: 24px; | ||
} | ||
|
||
.form-layout-top .nut-form-item-body { | ||
margin-left: 0; | ||
width: 100%; | ||
} | ||
|
||
[dir='rtl'] .form-layout-right .nut-form-item-label, | ||
.nut-rtl .form-layout-right .nut-form-item-label { | ||
text-align: left; | ||
padding-right: 0; | ||
padding-left: 24px; | ||
} | ||
|
||
[dir='rtl'] .form-layout-left .nut-form-item-label, | ||
.nut-rtl .form-layout-left .nut-form-item-label { | ||
text-align: right; | ||
padding-left: 0; | ||
padding-right: 12px; | ||
|
||
.required { | ||
left: auto; | ||
right: 0.1em; | ||
} | ||
} | ||
|
||
[dir='rtl'] .form-layout-top .nut-form-item-label, | ||
.nut-rtl .form-layout-top .nut-form-item-label { | ||
padding-right: 0; | ||
padding-left: 24px; | ||
} | ||
|
||
[dir='rtl'] .form-layout-top .nut-form-item-body, | ||
.nut-rtl .form-layout-top .nut-form-item-body { | ||
margin-left: 0; | ||
margin-right: 0; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,9 @@ export interface FormProps extends BasicComponent { | |
initialValues: any | ||
name: string | ||
form: any | ||
disabled: boolean | ||
divider: boolean | ||
validateTrigger: string | string[] | false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 文档是两个类型,不一致 |
||
labelPosition: 'top' | 'left' | 'right' | ||
starPosition: 'left' | 'right' | ||
onFinish: (values: any) => void | ||
|
@@ -22,7 +24,9 @@ const defaultProps = { | |
...ComponentDefaults, | ||
labelPosition: 'right', | ||
starPosition: 'left', | ||
disabled: false, | ||
divider: false, | ||
validateTrigger: 'onChange', | ||
onFinish: (values) => {}, | ||
onFinishFailed: (values, errorFields) => {}, | ||
} as FormProps | ||
|
@@ -43,8 +47,10 @@ export const Form = React.forwardRef<FormInstance, Partial<FormProps>>( | |
children, | ||
initialValues, | ||
divider, | ||
disabled, | ||
onFinish, | ||
onFinishFailed, | ||
validateTrigger, | ||
labelPosition, | ||
starPosition, | ||
form, | ||
|
@@ -96,7 +102,11 @@ export const Form = React.forwardRef<FormInstance, Partial<FormProps>>( | |
}} | ||
> | ||
<Cell.Group divider={divider}> | ||
<Context.Provider value={formInstance}>{children}</Context.Provider> | ||
<Context.Provider | ||
value={{ formInstance, labelPosition, disabled, validateTrigger }} | ||
> | ||
{children} | ||
</Context.Provider> | ||
{footer ? ( | ||
<Cell className={`${classPrefix}-footer`}>{footer}</Cell> | ||
) : null} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.