-
Notifications
You must be signed in to change notification settings - Fork 280
fix(countdown): 适配v14 && type增加text类型 #2701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3933a24
fix(countdown): 适配v14 && type增加text类型
irisSong eaa1c1a
fix(countdown): 判断是否补0
irisSong 2ad183a
fix(countdown): add test
irisSong e880ace
fix: cr update
irisSong 302f4d4
fix: test update
irisSong f0271e0
feat: add v14适配标识
irisSong d4adac8
fix: update icons-react-taro version
irisSong 847c2ed
chore: update pnpm-lock.yaml
irisSong a4f2168
fix: 合并v3.0
irisSong c791e44
Merge branch '3.0' into 3.0-countdown
irisSong 977bdd3
Merge remote-tracking branch 'upstream/V3.0' into 3.0-countdown
irisSong 8ef66a3
fix: 合并3.0
irisSong 6faa8c7
Merge remote-tracking branch 'upstream/V3.0' into 3.0-countdown
irisSong 7a2471d
fix: modify ts
irisSong 34665be
Merge remote-tracking branch 'upstream/V3.0' into 3.0-countdown
irisSong 6791a73
fix: delete harmony css
xiaoyatong c481d24
Merge branch 'V3.0' into 3.0-countdown
xiaoyatong 82fb4a7
fix: delete harmony css
xiaoyatong c127329
fix: types
xiaoyatong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 100 additions & 0 deletions
100
src/packages/countdown/__test__/__snapshots__/countdown.spec.tsx.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html | ||
|
|
||
| exports[`Countdown > type props primary 1`] = ` | ||
| <div> | ||
| <div | ||
| class="nut-countdown " | ||
| > | ||
| <span | ||
| class="nut-countdown-number-primary" | ||
| > | ||
| 00 | ||
| </span> | ||
| : | ||
| <span | ||
| class="nut-countdown-number-primary" | ||
| > | ||
| 00 | ||
| </span> | ||
| : | ||
| <span | ||
| class="nut-countdown-number-primary" | ||
| > | ||
| 00 | ||
| </span> | ||
| </div> | ||
| </div> | ||
| `; | ||
|
|
||
| exports[`Countdown > type props text 1`] = ` | ||
| <div> | ||
| <div | ||
| class="nut-countdown " | ||
| > | ||
| <span | ||
| class="nut-countdown-number-text" | ||
| > | ||
| 00 | ||
| </span> | ||
| : | ||
| <span | ||
| class="nut-countdown-number-text" | ||
| > | ||
| 00 | ||
| </span> | ||
| : | ||
| <span | ||
| class="nut-countdown-number-text" | ||
| > | ||
| 00 | ||
| </span> | ||
| </div> | ||
| </div> | ||
| `; | ||
|
|
||
| exports[`Countdown > type props text primary 1`] = ` | ||
| <div> | ||
| <div | ||
| class="nut-countdown " | ||
| > | ||
| <span | ||
| class="nut-countdown-number-text" | ||
| > | ||
| 00 | ||
| </span> | ||
| : | ||
| <span | ||
| class="nut-countdown-number-text" | ||
| > | ||
| 00 | ||
| </span> | ||
| : | ||
| <span | ||
| class="nut-countdown-number-text" | ||
| > | ||
| 00 | ||
| </span> | ||
| </div> | ||
| <div | ||
| class="nut-countdown " | ||
| > | ||
| <span | ||
| class="nut-countdown-number-primary" | ||
| > | ||
| 00 | ||
| </span> | ||
| : | ||
| <span | ||
| class="nut-countdown-number-primary" | ||
| > | ||
| 00 | ||
| </span> | ||
| : | ||
| <span | ||
| class="nut-countdown-number-primary" | ||
| > | ||
| 00 | ||
| </span> | ||
| </div> | ||
| </div> | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
建议增强
text类型的测试覆盖范围当前测试用例存在以下可以改进的地方：
建议按照以下方式增强测试：
test('type props text', async () => { + const endTime = Date.now() + 2000 const { container } = render( - <CountDown endTime={Date.now() + 1 * 1000} type="text" /> + <CountDown endTime={endTime} type="text" /> ) const countdownDom = container.querySelector('.nut-countdown') as Element - expect(container).toMatchSnapshot() + + // 验证初始渲染 expect( countdownDom?.querySelectorAll('.nut-countdown-number-text')?.length ).toBe(3) + + // 验证实际内容 + const numbers = countdownDom?.querySelectorAll('.nut-countdown-number-text') + expect(numbers[0]).toHaveTextContent('00') + + // 验证动态更新 + await act(async () => { + await sleep(1000) + waitFor(() => { + expect(numbers[0]).toHaveTextContent('00') + }) + }) + + // 验证分隔符 + const separators = countdownDom?.querySelectorAll('.nut-countdown-separator') + expect(separators).toHaveLength(2) })