Pass extra context to generate_challenge. #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom email templates might require some dynamic data. Make use of the unused extra_context parameter of EmailDevice, allowing custom view classes to set extra_context. Care is taken to only pass context if device generate_challenge actually supports an extra_context parameter. The base method does not define any parameters.
apapsch
force-pushed
the
context-data-for-email
branch
from
8101db8 to
aec8d73
Compare
moggers87
requested changes
Dec 19, 2025
Collaborator
moggers87
left a comment
moggers87
left a comment
There was a problem hiding this comment.
Looks good, just one comment that needs resolving.
Comment on lines
+45
to
+47
| generate_challenge = getattr(device, "generate_challenge", None) | ||
| if not callable(generate_challenge): | ||
| raise TypeError("Device has no generate_challenge method") |
Collaborator
There was a problem hiding this comment.
Do we need to test if device.generate_challenge callable? It's defined on the base Device model so I don't think this test is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Custom email templates might require some dynamic data. Make use of the unused extra_context parameter of EmailDevice, allowing custom view classes to set extra_context.
Care is taken to only pass context if device generate_challenge actually supports an extra_context parameter. The base method does not define any parameters.
Motivation and Context
Please see #786 for motivation and context.
How Has This Been Tested?
django-two-factor-authwere confirmed to finish without error.Types of changes
Checklist: