Skip to content

Conversation

@Dresdn
Copy link
Contributor

@Dresdn Dresdn commented Sep 1, 2024

I'm helping!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • [] I have updated the documentation for the changes I have made
  • [] I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

Other Information

  • This changes Attribute slugs to be "Python identifier compliant" by modifying how slugs are generated and validated. Doing this, all slugs can be referenced via dot notation now, eg providing name="my slug", the attribute can be accessed via instance.eav.my_slug

  • All special characters are converted to unicode, so Attributes created with "Age #" and "Age %" won't conflict, as they would by just using Django's utils.slugify().

@Dresdn Dresdn merged commit 41fa7dd into jazzband:master Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slugs with Hyphens Cannot Be Accessed via Entity __getattr__

1 participant