Skip to content

Conversation

@jacobjove
Copy link
Contributor

I'm helping!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

Other Information

@Dresdn
Copy link
Contributor

Dresdn commented Dec 2, 2023

Nice @iacobfred! This has been a long-standing todo bugging me :)

Copy link
Contributor

@Dresdn Dresdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you switch back to using the typing module for 3.8 compatibility?

@jacobjove jacobjove requested a review from Dresdn December 5, 2023 16:50
@Dresdn
Copy link
Contributor

Dresdn commented Dec 7, 2023

Thank you for the contribution @iacobfred!

@Dresdn Dresdn merged commit e1bc667 into jazzband:master Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants