Fix: AttributeError when optional settings are undefined #1375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1328
What does this PR do?
Problem
The
axes_conf_checkfunction accessed settings without a default value, causingAttributeErrorwhen optional settings likeAXES_CLIENT_STR_CALLABLE,AXES_USERNAME_CALLABLE, etc. were not explicitly defined insettings.py.Solution
Added
Noneas the default value togetattr(settings, callable_setting, None)in theaxes_conf_checkfunction. This aligns with the defaults defined inaxes/conf.pyand prevents the check from failing on undefined optional settings.Changes
getattron line 210test_missing_settings_no_errorto verify fixFixes #1328 -
AttributeErrorwhen starting Django server with django-axes installed but without explicitly defining all optional settings.Checks