Update scipy.signal.welch tests to be compatible with upstream dev version #28848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream PR scipy/scipy#22460 made some changes to the behavior of
scipy.signal.welchthat we started hitting as CI failures. There were 2 issues that we were seeing:The formatting of a warning was changed, so our existing warning ignore filter wasn't triggering.
The new version of the csd function is more restrictive about the allowed dtypes for the
windowarray. (I think there is actually a bug inscipywrt the handling of real data and complex window in the latest version. I'll report there!)