Skip to content

Исправление неточности в задании #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

mrkqstn
Copy link
Contributor

@mrkqstn mrkqstn commented Oct 15, 2023

В условии задания не уточнен сценарий, когда аолльзовател ничего не указывает в модальном окне запроса пароля.
Сам код в решении при этом имеет следующее условие:

} else if (pass === '' || pass === null) {
    alert( 'Отменено' );

Уточнил данное условие в самом аадагии, а так же отправлю новый pull-request с вариантом корректировки в самом коде.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Oct 15, 2023
@javascript-translate-bot javascript-translate-bot requested a review from a team October 15, 2023 19:04
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mrkqstn mrkqstn changed the title Исправление неточности в статье Исправление неточности в задании Oct 15, 2023
Copy link
Member

@Alexandre887 Alexandre887 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels Oct 16, 2023
@Alexandre887 Alexandre887 merged commit 118f9e9 into javascript-tutorial:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs +1 One more review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants