Fix incorrect IncompatibleClassChangeError in ClassInfo.getDefaultMethod #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic to detect if there are two conflicting default methods was incorrect. If a class and its superclass both implement the same interface JPF should not throw an IncompatibleClassChangeError.
|
Thanks for your contribution. Sorry for the slow action; we were busy setting up GSoC, but now we have Travis ready for future pull requests, so we can accept them much faster in the future. |
|
@cyrille-artho - No worries. Thanks for merging this! |
gayanW
pushed a commit
to gayanW/jpf-core
that referenced
this pull request
May 31, 2018
…hod (javapathfinder#7) The logic to detect if there are two conflicting default methods was incorrect. If a class and its superclass both implement the same interface JPF should not throw an IncompatibleClassChangeError.
cyrille-artho
pushed a commit
that referenced
this pull request
Aug 17, 2021
… Java programs. (#295) * add BitFlip annotation for parameters, fields and local variables * faulty implementation of getBitFlip API * Address the getBitFlip API issue by (1) moving the logic of choosing flipping positions to Java level and (2) call getInt__II__I only once in MJI level and decode. I keep the code of both approaches in Verify.java and JPF_gov_nasa_jpf_vm_Verify.java respectively. The one that takes effect for now is (2) in JPF_gov_nasa_jpf_vm_Verify.java, because with getBitFlip__JII__J method in JPF_gov_nasa_jpf_vm_Verify.java, JPF will execute getBitFlip__JII__J instead of getBitFlip in Verify.java. * explicitly limit up to 7 bits to flip, add more comment to explain the code * add local Example repository to JPF classpath in jpf.properties * add Verify.getBitFlip API for double, float and boolean typed variables * faulty implementation of bit flips for annotated arguments * move the examples into this repo * give the ChoiceGenerator of getBitFlip a unique String id * change the AnnotationSimpleExample to flip 2 bits; remove faulty implementation of parameter bit flips in JVMStackFrame.java * add listener-based parameter bit flip implementation * clear the lastFlippedBits entry after exploring all choices * delete deprecated example classes in src/tests * add JPF test class BitFlipTest.java to test getBitFlip API and @bitflip annotation * address issue #4 * refactor the code, move certain part of code out of BitFlipListener to StackFrame and Types, which can hopefully reduce code duplication later * partly resolve #5: add implementation for local variable and field annotations, but JPF cannot parse local variables internally; add tests for field annotations in BitFlipTest * uncomment the testLocalVariableBitFlip test, and annotate it with @ignore * resolve #6 by annotating local variables with type annotations * resolve #7 : add support for command line specified bit flips for fields, parameters and local variables; add tests for them in BitFlipTest.java * add more comment; add license for new files; clean unnessary changes; move the examples out * resolve issue #9: add 5 more complex tests for bit flips * small changes to some comments and variable/method names * change the new files to use the JPF Apache License
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to detect if there are two conflicting default methods was incorrect.
If a class and its superclass both implement the same interface JPF should not
throw an IncompatibleClassChangeError.