Remove unnecessary assertion in String#getBytes(byte[], int, byte) #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jpf-core/src/classes/modules/java.base/java/lang/String.java
Lines 249 to 260 in 9ebb98c
Our initial conclusion that the coder is always UTF16 is wrong. As it states "If two coders are different and the target is big enough, invoker guarantees that the target is in UTF16 ". So the invoker guarantees not to call when the source encoding is UTF-8 and the target is in LATIN-1.
But what if the source and target encoding are in "UTF-8". So the assertion statement needs to be removed.
This also fixes:
The error can be seen on ObjectStreamTest, ClassLoaderTest, StringTest and in a few other tests.