Open
Conversation
colingm
approved these changes
Mar 4, 2026
Contributor
colingm
left a comment
colingm
left a comment
There was a problem hiding this comment.
I know an approval here is not required as this is already out there but I appreciate being able to see all of the changes for that version here and what the vuln was.
Collaborator
Author
|
Thank you, @colingm. Approval is not required, but criticism is still welcome and I would also follow up on it. So if you spot anything that you'd want to be different, please do not hesitate to let me know. This applies to all reviewers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a retroactive pull request with the sole purpose to enable public review. The changes in the diff were already released and merged into master and also published to the website.
For context, see #3011 and GHSA-qpx9-hpmf-5gmw.
The 1.13.8 release as it was published to NPM had some obfuscations applied to the code comments. Those obfuscations were added in 42823bb before publication and removed again in 45ea015 after publication. There are no differences in the logic between what is shown here and what was published to NPM.
I'm specifically attracting attention from @ByamB4 and @GammaGames, but everyone is welcome to review.