Typechecks and isEqual support for ArrayBuffer, DataView and typed arrays #2844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the patch into the index.js and also updates the typed array information a little bit.
|
This looks really nice to me! 👏 |
jashkenas
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated and polished continuation of #2694. Merging this PR will (should?) also merge the other.
@jashkenas I'm requesting your review again because I ended up making quite substantial changes compared to the original PR that you already reviewed:
isArrayBuffer,isDataViewandisTypedArrayfunctions. These are also tested.isBufferLikefunction that follows the pattern ofisArrayLike(withbyteLengthinstead oflength) and factored out the common logic.isEqualuntouched.BigInt64ArrayandBigUint64Array, which probably didn't exist yet in 2018.I could not entirely avoid listing the typed array constructor names, because typed arrays appeared in IE10 while
ArrayBuffer.isViewappeared only in IE11. However, I was able to compress the list into a regular expression.Edit to add: You can support my work on Underscore and other open source projects on Patreon.