Skip to content

sqlite - feat: adding in benchmarks#1885

Merged
jaredwray merged 4 commits into
mainfrom
sqlite---feat-adding-in-benchmarks
Mar 21, 2026
Merged

sqlite - feat: adding in benchmarks#1885
jaredwray merged 4 commits into
mainfrom
sqlite---feat-adding-in-benchmarks

Conversation

@jaredwray

@jaredwray jaredwray commented Mar 21, 2026

Copy link
Copy Markdown
Owner

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
sqlite - feat: adding in benchmarks

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a refactoring of the SQLite storage module's benchmarking suite. The primary goal is to consolidate and simplify the execution of performance tests across different SQLite drivers. By merging driver-specific benchmarks and streamlining the package.json scripts, the changes aim to provide a more efficient and unified approach to measuring the performance of the Keyv SQLite adapter.

Highlights

  • Benchmark Consolidation: The benchmarks for node:sqlite and better-sqlite3 drivers have been consolidated into a single file, node-sqlite.ts, streamlining the benchmarking process.
  • Simplified Benchmark Execution: The package.json scripts have been updated to simplify running benchmarks, now executing a single script that covers multiple drivers.
  • Benchmark Logic Refinement: The bun-sqlite benchmark was refined to combine set and get operations into a single test, and the node-sqlite benchmark now includes warm-up and testing for both node:sqlite and better-sqlite3 drivers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Comment thread storage/sqlite/benchmark/node-sqlite.ts

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the benchmark scripts by consolidating them. The changes are logical, combining the better-sqlite3 and node:sqlite benchmarks for direct comparison. I've found one minor issue where a database connection is not being closed, which could lead to a resource leak in the benchmark environment. I've left a specific comment with a suggestion to fix it.

Comment thread storage/sqlite/benchmark/node-sqlite.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f72a236f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread storage/sqlite/package.json Outdated
@codecov

codecov Bot commented Mar 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (ba4d611) to head (7903968).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1885   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          35       35           
  Lines        3274     3274           
  Branches      566      566           
=======================================
  Hits         3273     3273           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit c632b46 into main Mar 21, 2026
10 checks passed
@jaredwray jaredwray deleted the sqlite---feat-adding-in-benchmarks branch March 21, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant