Support LaTeX comments#3
Merged
Merged
Conversation
Owner
|
@xarantolus thanks for the contribution! I didn't notice any issues in my tests and I don't anticipate any so we'll cross that bridge if we run into issues with other file types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for this cool and simple tool.
I noticed that it didn't support comment lines that start with a percentage sign, such as the ones in LaTeX.
So I edited the regex to also include it, and in my tests it seems to work correctly.
It now also marks lines that look like this, and all other starting keywords:
If you have any ideas on how this could interfere with other file types please let me know.