Tweaks to Bean and Event Assignability API#742
Merged
manovotn merged 1 commit intojakartaee:mainfrom Jan 13, 2024
Merged
Conversation
* use code tags for true and false * consistently use @ with annotation classes * fix wrong method name in spec * add anchor name to spec * no implied Default qualifier for events * Change "beans and observers" to "beans and events" in spec for consistency
manovotn
approved these changes
Jan 12, 2024
Contributor
manovotn
left a comment
manovotn
left a comment
There was a problem hiding this comment.
no implied Default qualifier for events
Ah, good catch, thank you.
The rest are nice quality of life changes; appreciate having another pair of eyes double checking for these changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #700 with a few things I noticed while writing TCKs in jakartaee/cdi-tck#526:
Defaultqualifier for eventsRelates to issue #498