Initial beans_4_0.xsd#517
Merged
starksm64 merged 6 commits intojakartaee:masterfrom Sep 8, 2021
jakartaredhat:master
Merged
Conversation
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
… beans-discovery-mode Addresses #497 Signed-off-by: Scott M Stark <starksm64@gmail.com>
Ladicek
reviewed
Sep 8, 2021
Ladicek
reviewed
Sep 8, 2021
Ladicek
approved these changes
Sep 8, 2021
Member
Ladicek
left a comment
Ladicek
left a comment
There was a problem hiding this comment.
Looks good, just 2 minor suggestions.
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Member
|
I also suggested to fix the "this is the only configuration value read from a beans.xml file is the beans bean-discovery-mode attribute" malformed sentence, but that's a minor thing really. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squash merge this as I could not squash it locally.