This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Fixing RemoteBaggageRestrictionManager NullPointerException on empty response#631
Merged
yurishkuro merged 1 commit intojaegertracing:masterfrom May 22, 2019
Merged
Conversation
…response Signed-off-by: Raviraj Joshi <ravirajj@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
===========================================
+ Coverage 89.51% 89.62% +0.1%
- Complexity 561 564 +3
===========================================
Files 69 69
Lines 2061 2063 +2
Branches 261 262 +1
===========================================
+ Hits 1845 1849 +4
+ Misses 136 134 -2
Partials 80 80
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
RemoteBaggageRestrictionManagerattempted to update baggage restrictions:restrictionsresponse may benullbecausegson.fromJson()returnsnullwhenHttpBaggageRestrictionManagerProxyreceives an empty response from the remote server.Short description of the changes
BaggageRestrictionManagerExceptionif the restrictions response is empty.