Skip to content
This repository was archived by the owner on Jul 1, 2022. It is now read-only.

Fixing RemoteBaggageRestrictionManager NullPointerException on empty response#631

Merged
yurishkuro merged 1 commit intojaegertracing:masterfrom
ravirajj:rj.baggage
May 22, 2019
Merged

Fixing RemoteBaggageRestrictionManager NullPointerException on empty response#631
yurishkuro merged 1 commit intojaegertracing:masterfrom
ravirajj:rj.baggage

Conversation

@ravirajj
Copy link
Copy Markdown
Contributor

Which problem is this PR solving?

Exception in thread "Timer-1" java.lang.NullPointerException
    at io.jaegertracing.internal.baggage.RemoteBaggageRestrictionManager.updateBaggageRestrictions(RemoteBaggageRestrictionManager.java:93)
    at io.jaegertracing.internal.baggage.RemoteBaggageRestrictionManager.updateBaggageRestrictions(RemoteBaggageRestrictionManager.java:87)
    at io.jaegertracing.internal.baggage.RemoteBaggageRestrictionManager$1.run(RemoteBaggageRestrictionManager.java:67)
    at java.util.TimerThread.mainLoop(Timer.java:555)
    at java.util.TimerThread.run(Timer.java:505)

Short description of the changes

  • Throw BaggageRestrictionManagerException if the restrictions response is empty.

…response

Signed-off-by: Raviraj Joshi <ravirajj@uber.com>
@codecov
Copy link
Copy Markdown

codecov bot commented May 22, 2019

Codecov Report

Merging #631 into master will increase coverage by 0.1%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #631     +/-   ##
===========================================
+ Coverage     89.51%   89.62%   +0.1%     
- Complexity      561      564      +3     
===========================================
  Files            69       69             
  Lines          2061     2063      +2     
  Branches        261      262      +1     
===========================================
+ Hits           1845     1849      +4     
+ Misses          136      134      -2     
  Partials         80       80
Impacted Files Coverage Δ Complexity Δ
...ernal/baggage/RemoteBaggageRestrictionManager.java 94.91% <50%> (-5.09%) 11 <0> (+1)
...gertracing/internal/reporters/LoggingReporter.java 90.9% <0%> (+9.09%) 5% <0%> (+1%) ⬆️
...rtracing/internal/reporters/CompositeReporter.java 100% <0%> (+28.57%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e73cc...c2cd86e. Read the comment docs.

@yurishkuro yurishkuro merged commit 11c22cb into jaegertracing:master May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants