This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Fix repeated resolving of sender in configuration#555
Merged
pavolloffay merged 3 commits intojaegertracing:masterfrom Sep 19, 2018
Merged
Fix repeated resolving of sender in configuration#555pavolloffay merged 3 commits intojaegertracing:masterfrom
pavolloffay merged 3 commits intojaegertracing:masterfrom
Conversation
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
ghost
assigned
yurishkuro
approved these changes
Sep 19, 2018
| } | ||
|
|
||
| return SenderResolver.resolve(this); | ||
| return (sender = SenderResolver.resolve(this)); |
Member
There was a problem hiding this comment.
nit:
if sender == null {
sender = resolve()
}
return sender
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
============================================
+ Coverage 88.76% 88.81% +0.04%
Complexity 519 519
============================================
Files 67 67
Lines 1896 1895 -1
Branches 243 243
============================================
Hits 1683 1683
- Misses 138 139 +1
+ Partials 75 73 -2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay ploffay@redhat.com