This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Close tracer on JVM shutdown#546
Merged
jpkrohling merged 1 commit intojaegertracing:masterfrom Sep 7, 2018
Merged
Conversation
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
============================================
+ Coverage 88.64% 88.76% +0.12%
- Complexity 517 519 +2
============================================
Files 67 67
Lines 1893 1896 +3
Branches 243 243
============================================
+ Hits 1678 1683 +5
+ Misses 141 138 -3
- Partials 74 75 +1
Continue to review full report at Codecov.
|
objectiser
approved these changes
Sep 7, 2018
|
Thanks! Looking forward to the next release! |
yurishkuro
reviewed
Sep 7, 2018
| this.tags = Collections.unmodifiableMap(tags); | ||
|
|
||
| // register this tracer with a shutdown hook, to flush the spans before the VM shuts down | ||
| Runtime.getRuntime().addShutdownHook(new Thread() { |
Member
There was a problem hiding this comment.
what will this do to unit tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de
Which problem is this PR solving?
Short description of the changes
tracer.close(), I see this in the logs for the client:But nothing on the server side. Starting an all-in-one container with
--log-level=debugconfirms that nothing is received on that end.With this PR applied, I do see the trace:
And on the server side:
{"level":"debug","ts":1536316839.6288192,"caller":"app/span_processor.go:104","msg":"Span written to the storage by the collector","trace-id":"3ce5effda0536731","span-id":"3ce5effda0536731"}