Handle Nil response body from SigV4#749
Merged
jacksontj merged 1 commit intojacksontj:masterfrom Mar 18, 2026
Merged
Conversation
Contributor
Author
|
Just to provide some context, here is the panic we got when would get a nil response body. I am also submitting this fix to prometheus/sigv4 to fix this in other places |
Contributor
Author
|
Tests Passing: |
Contributor
Author
|
@pedroapero would you be able to take a look at this? Small change to handle an edge case from the SigV4 work. |
TheMeier
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in #746 we added the capability for SigV4 support. This worked but did not handle the case where the response for a certain query was Nil. This caused a panic. In this change we handle the Nil case to prevent panic.