Skip to content

Conversation

Fijxu
Copy link
Member

@Fijxu Fijxu commented Sep 14, 2025

Closes #5456

The 84codes Crystal container image builds libgc (bdwgc) with --enable-large-config: https://github.com/84codes/crystal-packages/blob/b321bb4358b0140a63573d9d05ccf2f06c5ae040/alpine/Dockerfile#L13-L22

I tested it locally and I'm now going to test it on my fork of Invidious https://git.nadeko.net/Fijxu/invidious/commit/b38791e7ca6b7549e3a894f26f43cb77660c798e

@Fijxu Fijxu requested a review from syeopite September 14, 2025 02:38
@Fijxu Fijxu requested a review from unixfox as a code owner September 14, 2025 02:38
@Fijxu Fijxu added the docker Pull requests that update docker code label Sep 14, 2025
@unixfox
Copy link
Member

unixfox commented Sep 14, 2025

Ah so this image fixes the memory leak?

@Fijxu
Copy link
Member Author

Fijxu commented Sep 14, 2025

Ah so this image fixes the memory leak?

No, this is unrelated to the memory leak. It just improves GC performance and for now, my Invidious processes seem to use less memory.

2fd67c34-000f-40ed-9d5b-04f1def58b93

At 00:00 is when I changed my instance to the 84codes container image to build Invidious.

@Fijxu
Copy link
Member Author

Fijxu commented Sep 15, 2025

After approximately 1 day and 12 hours I can confirm that the 84codes container image which uses --enable-large-config for bdwgc has a more stable memory usage when combining it with #5441. There is no memory limits (mem_limit) on my docker-compose file and I have around 8GB of memory free that Invidious could use, but the memory usage is stable ;):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Recompile Crystal's garbage collector (bdwgc) with --enable-large-config
2 participants