feat: install payload delay #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/add-delayed-resolver
branch
from
79a7833 to
3069865
Compare
onbjerg
requested changes
Jan 22, 2025
Contributor
onbjerg
left a comment
onbjerg
left a comment
There was a problem hiding this comment.
im a bit wary of merging with the chain advancement test failing, can you verify that it is still advancing and the test might just be flaky?
onbjerg
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a hack that wraps the engine_getPayloadV3 and applies a delay, that delays the request up to 500ms into the slot.
the motivation for this is, so we can give the payload builder a bit more time to include more txs, because the previous block building window was observed to be ~250ms